Posted by grub3 on August 20, 2009 at 8:26pm
| Project: | Event |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
Very nice module, congrats.
Minor problem under PostgreSQL 8.4
When connecting to:
users/admin
This message is displayed:
* warning: pg_query() [function.pg-query]: Query failed: ERREUR: l'opérateur n'existe pas : character varying = integer LINE 1: UPDATE users SET timezone_id = 320 WHERE timezone = 7200 AND... ^ HINT: Aucun opérateur ne correspond au nom donné et aux types d'arguments. Vous devez ajouter des conversions explicites de type. in /home/html/drupal/includes/database.pgsql.inc on line 139.
* user warning: query: UPDATE users SET timezone_id = 320 WHERE timezone = 7200 AND timezone_id = 0 in /home/html/drupal/sites/all/modules/event/event.module on line 275.In users table, timezone is a character varying(8).
Very strange, because it includes integer values.
PostgreSQL does not cast values from varchar to integer automatically.
WHERE timezone = 7200 fails.
We need to cast the value in PHP before it is sent to the database.
Bye, Jean-Michel
Comments
#1
I could use this patch:
Index: event.module===================================================================
--- event.module (révision 614)
+++ event.module (copie de travail)
@@ -272,7 +272,7 @@
// Lookup TZ ID based on TZ offset
$timezone_id = event_timezone_map($user->timezone);
// Update all users with the same offset.
- db_query('UPDATE {users} SET timezone_id = %d WHERE timezone = %d AND timezone_id = 0', $timezone_id, $user->timezone);
+ db_query('UPDATE {users} SET timezone_id = %d WHERE timezone = CAST (%d AS VARCHAR) AND timezone_id = 0', $timezone_id, $user->timezone);
}
}
}
This seem to be SQL99 safe, please apply after review.
#2
Please discard this patch. My fault, sorry.
#3
Correct patch.
#4
Please read this reference doc between MySQL and PostgreSQL:
http://drupal.org/node/555536
#5
Patch needs review.