Here's a patch to enable users to install the videoplayer file through drush instead of having to download it manually.

CommentFileSizeAuthor
flashy-drush.patch1.72 KBeabrand

Comments

moshe weitzman’s picture

Status: Active » Needs review

good idea. found minor points ...

missing command help. just a brief one liner.

+++ flashy.drush.inc	20 Aug 2009 22:20:18 -0000
@@ -0,0 +1,54 @@
+  if (file_exists($filename) || drush_get_context('DRUSH_SIMULATE')) {

I don't think SIMULATE should say that. it is lying.

+++ flashy.drush.inc	20 Aug 2009 22:20:18 -0000
@@ -0,0 +1,54 @@
+    return drush_print("Downloading $file was successful to $filename.");

minor ... use drush_log("Downloading $file was successful to $filename.", 'success'). this is better for remotely executed commands

strings should be emitted inside of dt(). thats the drush equivalent of t()

This review is powered by Dreditor.

Crell’s picture

Also, after some discussion with Moshe in IRC we decided that "post-install" was probably a better command name standard than "install".

Crell’s picture

Status: Needs review » Fixed

Committed with the comments from #1 and #2 addressed. Yay!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.