http://drupal.org/node/541708 generates a commit message like this:

#541708 by webchick, catch | dropcube: Fixed Unnecessary query in _filter_tips().

Both catch and I only uploaded one patch, but my name is first because I was the last to comment.

It'd be nice if the number of patches submitted were equal, the person who commented earlier was listed first.

CommentFileSizeAuthor
#4 555304_dreditor.patch845 bytesericduran
#3 555304.dreditor.patch849 bytesericduran

Comments

dave reid’s picture

Why is the "| username" being included as well. I don't know what that is. Often times it's a user who didn't make a contribution to the issue.

sun’s picture

Title: Fix weighting of commit message. » Fix weighting of usernames in commit message

The pipe separates patch contributors from comment contributors.

Marked #686554: user separator in commit message as duplicate.

ericduran’s picture

StatusFileSize
new849 bytes

I went to multiple issues queues and counted the patches submitted :-) this looks ok to me.

So this will list the submitters in order of the most patches , and if the count is the same it'll list it in the order the comment was posted.

This will need some serious testing.

ericduran’s picture

Status: Active » Needs review
StatusFileSize
new845 bytes

Minor cosmetic fixes and switching status.

sun’s picture

Thought about this a bit. Let's do a "real" commit message generator instead.

I.e., à la http://drupal.org/node/468272

Every user(name) is a "tag", click to add further, X to remove.

Using hard-coded internal weights.