| Project: | Organic groups |
| Version: | 6.x-2.0 |
| Component: | og.module |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Please help! I need OG running ASAP
There weren't any specific update instructions in the README regarding updates within D6 so I used the process I have done before with other modules. I hope this was right.
1. I disabled organic groups.
2. I also disabled messaging and notifications since I wasn't able to get notifications to send out email notices when someone posted to a group.
3. I deleted OG1.3 from the server and uploaded OG2.0
4. I returned to my site and ran update.php
5. Got the following error message.
Drupal database update
* user warning: Unknown column 'is_public' in 'field list' query: INSERT INTO og_access_post (nid, og_public) SELECT DISTINCT(nid), (SELECT is_public FROM og_ancestry oga_sub WHERE oga_sub.nid = oga.nid LIMIT 1) FROM og_ancestry oga in /home/idcmi/idcminnovations.com/html/sites/all/modules/og/modules/og_access/og_access.install on line 80.
* user warning: Can't DROP 'is_public'; check that column/key exists query: ALTER TABLE og_ancestry DROP is_public in /home/idcmi/idcminnovations.com/html/includes/database.mysql-common.inc on line 322.
Updates were attempted. If you see no failures below, you may proceed happily to the administration pages. Otherwise, you may need to update your database manually. All errors have been logged.
* Main page
* Administration pages
The following queries were executed
og_notifications module
Update #6001
* No queries
og module
Update #6203
* ALTER TABLE {og_ancestry} DROP is_public
* CREATE TABLE {og_ancestry_new} ( `nid` INT NOT NULL, `group_nid` INT NOT NULL ) /*!40100 DEFAULT CHARACTER SET UTF8 */
* INSERT INTO {og_ancestry_new} SELECT DISTINCT * FROM {og_ancestry}
* DROP TABLE {og_ancestry}
* ALTER TABLE {og_ancestry_new} RENAME TO {og_ancestry}
* ALTER TABLE {og_ancestry} ADD PRIMARY KEY (nid, group_nid)
og_access module
Update #6201
* CREATE TABLE {og_access_post} ( `nid` INT NOT NULL, `og_public` TINYINT NOT NULL DEFAULT 1, PRIMARY KEY (nid) ) /*!40100 DEFAULT CHARACTER SET UTF8 */
* Failed: INSERT INTO {og_access_post} (nid, og_public) SELECT DISTINCT(nid), (SELECT is_public FROM {og_ancestry} oga_sub WHERE oga_sub.nid = oga.nid LIMIT 1) FROM {og_ancestry} oga
* Failed: ALTER TABLE {og_ancestry} DROP is_public
* CREATE TABLE {og_ancestry_new} ( `nid` INT NOT NULL, `group_nid` INT NOT NULL ) /*!40100 DEFAULT CHARACTER SET UTF8 */
* INSERT INTO {og_ancestry_new} SELECT DISTINCT * FROM {og_ancestry}
* DROP TABLE {og_ancestry}
* ALTER TABLE {og_ancestry_new} RENAME TO {og_ancestry}
* ALTER TABLE {og_ancestry} ADD PRIMARY KEY (nid, group_nid)
Comments
#1
I got the same exact error.
#2
I believe I've fixed this with a very simple tweak in og_access: change "is_public" to "oga_sub.is_public" in line 80.
I.e., change line 80 to this:
$ret[] = update_sql("INSERT INTO {og_access_post} (nid, og_public) SELECT DISTINCT(nid), (SELECT oga_sub.is_public FROM {og_ancestry} oga_sub WHERE oga_sub.nid = oga.nid LIMIT 1) FROM {og_ancestry} oga");I've attached a patch that I believe should work. This is my first time submitting a patch, so please be gentle and tell me if I've done anything incorrectly.
I think you'll need to restore your database to how it was before the failed upgrade attempt before applying the patch/fix.
--Rob
#3
thanks. i will give it a try on my dev acct. as soon as i can. really appreciate it!
c
#4
Can anyone confirm that this fixes the problem and preserves data properly?
#5
I just upgraded and got the same errors. It looks like the og module update removes the field 'is_public' from the og_ancestry table then the og_access module update tries to SELECT from that field.
#6
I also get the same error. Followed the same procedure of disabling OG modules, deleting the files, uploading the new files, then running update.php.
#7
I got swamped with work and haven't tested this yet. sorry. Sounds like folks are still having problems. I won't get to it until next month probably. again, sorry for the delay but gotta pay the bills ;-)
#8
same problem here, subscribing ..
#9
the above patch works for me, but only if i don't remove/deinstall og 1.3 before upgrading. so what i did was to replace the og module folder, apply the patch, run update.php - that's it ..
#10
I got the exact same errors when trying an upgrade from 5.x to 6.x (5.x-8.1 to 6.x-2.0)
#11
I finally got an opening in my calendar. I tried the patch - no errors! Yippie!!
thanks
c
#12
committed. thanks.
#13
Automatically closed -- issue fixed for 2 weeks with no activity.
#14
I realize this issue is closed, but I hope that relating my experience will help. We upgraded from 1.3 to 1.4 and experienced this same issue. Couldn't figure out why we were getting the warning messages as outlined in this initial post.
We then upgraded to v 2.1, updated og 6203 and og access to 6201 but had a failure in update with og_access as outlined below:
og_access module
Update #6201
• Failed: CREATE TABLE {og_access_post} ( `nid` INT NOT NULL, `og_public` TINYINT NOT NULL DEFAULT 1, PRIMARY KEY (nid) ) /*!40100 DEFAULT CHARACTER SET UTF8 */
• Failed: INSERT INTO {og_access_post} (nid, og_public) SELECT DISTINCT(nid), (SELECT oga_sub.is_public FROM {og_ancestry} oga_sub WHERE oga_sub.nid = oga.nid LIMIT 1) FROM {og_ancestry} oga
• Failed: ALTER TABLE {og_ancestry} DROP is_public
• CREATE TABLE {og_ancestry_new} ( `nid` INT NOT NULL, `group_nid` INT NOT NULL ) /*!40100 DEFAULT CHARACTER SET UTF8 */
• INSERT INTO {og_ancestry_new} SELECT DISTINCT * FROM {og_ancestry}
• DROP TABLE {og_ancestry}
• ALTER TABLE {og_ancestry_new} RENAME TO {og_ancestry}
• ALTER TABLE {og_ancestry} ADD PRIMARY KEY (nid, group_nid)
I am not an expert in code or databases. So I'm not entirely sure what this means, but perhaps this is helpful. What I do know is that the warnings NO LONGER appear, the site is now fully funcitonal, the organic groups are fully functional and it appears everything is working smoothly. My instinct tells me that the update errors appeared because of some of the things that happened in the 1.3 to 1.4 and I am going to assume (dangerous) that everything is now corrected.
Please advise if there is something more we should do, but I posted this in the interest of sharing information. Information leads to understanding.
To the maintainers of og, by the way, thanks for all you do. Enormously useful in our work with schools, teachers and kids.
geoff