Closed (fixed)
Project:
XML sitemap
Version:
6.x-2.x-dev
Component:
Documentation
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Aug 2009 at 09:28 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent
Comments
Comment #1
dave reidThe better question is, why does Drupal allow the base module to be uninstalled first when all the sub-modules depend on it... Odd.
Comment #2
manfer commentedLol, I didn't thought of that. Yes looks a buggy core feature. :)
I'm testing with a 6.12 version so can't confirm if it is still present on 6.13. But anyway it is drupal core issue.
Comment #3
dave reidYeah this is def. a core bug: #151452: Uninstalling modules does not follow dependencies and can lead to WSOD. There are so many dependencies between the base xmlsitemap module and the sub-modules that it would be a pain to work around. For now, just uninstall the sub-modules separately first, then uninstall the base module. I'll try to update documentation for this.
Comment #4
dave reidComment #5
Anonymous (not verified) commentedThe only method to fix the core bug is to have hook weights independent of module weights and that isn't going to happen anytime soon. Is it possible to resolve the issue with module weights?
Comment #6
dave reidWe're already using module weights in 6.x-2.x. All the submodules have a weight of 0, while the base module's weight is 1. I think xmlsitemap_engines is 2 though. If the uninstall ran on weights, the submodules would be first, but that's not the case: it's alphabetical and hence xmlsitemap.module uninstalls before xmlsitemap_custom.module.
The bigger problem is that we install modules by a dependency system, but we don't do the same on uninstall.
Comment #7
dave reidAdded this to the README.txt.
http://drupal.org/cvs?commit=304608