We could do to refactor the code so filefield_upload_limit_get_field_upload_limit() is always used, in which case filefield_upload_limit_is_set() becomes a helper function for that alone.
We could do to refactor the code so filefield_upload_limit_get_field_upload_limit() is always used, in which case filefield_upload_limit_is_set() becomes a helper function for that alone.
Comments
Comment #1
joachim commentedMy plan is roughly:
filefield_upload_limit_filefield should merely say: "what's the limit here?"and enforce it.
filefield_upload_limit_get_field_upload_limit() should return the effective limit for the given field -- so it does the job of figuring out if it's a custom limit, upload module, which role, whatever. It's just a magic box to which you say 'gimme the limit that matters'.
We could actually fold filefield_upload_limit_is_set into that -- depends what makes for neatest code.
Comment #2
greg.harveyClosing this, as realistically this will never happen - D5 end of life imminent, no further support will be given unless someone else takes it over.