The following private functions in uc_payment are all used outside the uc_payment module:

_payment_gateway_data()
_payment_gateway_list()
_payment_method_data()
_payment_method_list()

I would also like to use these functions without being concerned they may change or disappear - they should be renamed as regular public functions since they are being used as such.

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: private functions » Make private payment method/gateway functions public instead
Version: 6.x-2.x-dev » 7.x-3.x-dev
Assigned: Unassigned » Island Usurper

These have been renamed but are still private in 7.x. This is still something to consider though as they can be useful to other modules - but if this change is going to be made, it must be done before 7.x-3.0!

Island Usurper’s picture

Island Usurper commented

I don't feel like these functions need to remain private, but it may be worth considering if we can make them easier to use. It may just be that they are private functions, but I have always felt that they were awkward and inefficient. It'll be harder to improve the interface here once they are public functions.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Closed (won't fix)

Too late to do this now.