Newsletter footer is ommitted when role synchronized

jecheve - August 21, 2009 - 17:28
Project:Simplenews Roles
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

Footer (standard or customized) is omitted when sending a newsletter issue from a newsletter series synchronized to a role by means of Simplenews Roles. Footer is included if role synchronization is not selected.

Any help?

#1

joachim - August 21, 2009 - 21:16

Yeah, this module removes the footer -- because you can't unsubscribe, basically.

Once unsubscribing DOES work, the footer removal will go.

#2

jecheve - August 22, 2009 - 12:07

And who has said the footer is only, or mainly, for unsubscribing? It is the default, but as you know it is configurable. You can add whatever you want and, of course, remove subscribing. For all newsletters or for a specific series. It is a footer in Simplenews, not an unsubscribing form.

#3

joachim - August 22, 2009 - 12:57

Good point.

Though I wasn't planning on doing another release on the old branch.
Basically, the 0.1 release is just a snapshot for posterity, and both it and the 1.0 branch are fundamentally broken without the news code in simplenews 2.0 branch.

#4

joachim - November 6, 2009 - 13:17
Status:active» fixed

Unsubscribing now works, and so fixing this is simply a case of removing our simplenews_roles_mail_alter().

Changed in CVS:
#555924 by joachim: Removed removal of newsletter footers.

Will be in next dev release update.

#5

System Message - November 20, 2009 - 13:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.