This is one of the worst performing functions in core, it's been disabled by Drupal.org for at least the past 2-3 years, and it's preprocessed out in advanced forum, it's also nothing like what any of the major forum applications do.

Here's various wtf/perfomance issues:
#70578: overhead/private function call to generate forum navigation
#115442: Remove forum topic navigation from your posts
http://lists.drupal.org/pipermail/development/2006-July/017886.html
http://www.mailfunnel.org/development@drupal.org/2007-07/msg00471.html

6.x/HEAD/advanced_forum/advanced_forum.module:    foreach ($theme_registry['forum_topic_navigation']['preprocess functions'] as $key => $value) {
6.x/HEAD/advanced_forum/advanced_forum.module:      if ($value = 'template_preprocess_forum_topic_navigation') {
6.x/HEAD/advanced_forum/advanced_forum.module:        unset($theme_registry['forum_topic_navigation']['preprocess functions'][$key]);

Time to go.

CommentFileSizeAuthor
#4 forum_topic_navigation.patch5.92 KBdawehner
#1 forum_topic_navigation.patch0 bytesdawehner
forum_topic_navigation.patch4.48 KBcatch

Comments

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new forum_topic_navigation.patch0 bytes

Shouldn't the css be removed too?

There is also an example in system.api.php, I think it should be removed too.

6.x/HEAD/advanced_forum/advanced_forum.module:    foreach ($theme_registry['forum_topic_navigation']['preprocess functions'] as $key => $value) {
6.x/HEAD/advanced_forum/advanced_forum.module:      if ($value = 'template_preprocess_forum_topic_navigation') {
6.x/HEAD/advanced_forum/advanced_forum.module:        unset($theme_registry['forum_topic_navigation']['preprocess functions'][$key]);

is also in system.api.php as example, I'm not sure, whether it should be left in.

catch’s picture

catch
he/him
Primary language English
commented

The patch file seems to be empty. We should probably find another example for system.api.php yeah ;)

dries’s picture

dries commented

I support removing this function.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new forum_topic_navigation.patch5.92 KB

So here is the reupload.

dries’s picture

dries commented

Interestingly enough, I can't apply this patch so asking for a re-test.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks!

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

Actually, some forum software does have this, they just don't glom it on to the end of the text like Drupal does. AF 2.x moves it to a more sensible place at the end of the thread but does leave the warning that the query isn't good on large forums. I'm curious, is the query unfixable? I'll likely still offer it as an option in AF in D7 and it would be lovely if the query was better but I understand if you'd rather simply take it out of core rather than fix it.

Michelle

catch’s picture

catch
he/him
Primary language English
commented

The query's not unfixable, I think there's some suggestions buried on the development list from 2006/7 on how to fix it, but wasn't able to find these (whereas I found a lot of complaints about it). Grab me in irc when you want to work on this and I'll try to resurrect a better query.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

@catch: Ok, will do. Thanks. Would be nice to still have this as an option in AF for folks who like the feature. Less complaints about it being taken out of core, then. :)

Michelle

grub3’s picture

grub3 commented

Why not integrate the source code of this module into core:
http://drupal.org/project/prev_next

The code is available.
Why not use it.

catch’s picture

catch
he/him
Primary language English
commented

That should at least be used for AF, but I'd not heard of it until you linked to it just now.

grub3’s picture

grub3 commented

Okay, I am glad this feature was remove.
It was a great overhead for forums like ours.

Bye and thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.