Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
forum.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
21 Aug 2009 at 21:46 UTC
Updated:
14 May 2010 at 16:23 UTC
Jump to comment: Most recent file
Comments
Comment #1
dawehnerShouldn't the css be removed too?
There is also an example in system.api.php, I think it should be removed too.
is also in system.api.php as example, I'm not sure, whether it should be left in.
Comment #2
catchThe patch file seems to be empty. We should probably find another example for system.api.php yeah ;)
Comment #3
dries commentedI support removing this function.
Comment #4
dawehnerSo here is the reupload.
Comment #5
dries commentedInterestingly enough, I can't apply this patch so asking for a re-test.
Comment #6
dries commentedCommitted to CVS HEAD. Thanks!
Comment #7
michelleActually, some forum software does have this, they just don't glom it on to the end of the text like Drupal does. AF 2.x moves it to a more sensible place at the end of the thread but does leave the warning that the query isn't good on large forums. I'm curious, is the query unfixable? I'll likely still offer it as an option in AF in D7 and it would be lovely if the query was better but I understand if you'd rather simply take it out of core rather than fix it.
Michelle
Comment #8
catchThe query's not unfixable, I think there's some suggestions buried on the development list from 2006/7 on how to fix it, but wasn't able to find these (whereas I found a lot of complaints about it). Grab me in irc when you want to work on this and I'll try to resurrect a better query.
Comment #9
michelle@catch: Ok, will do. Thanks. Would be nice to still have this as an option in AF for folks who like the feature. Less complaints about it being taken out of core, then. :)
Michelle
Comment #10
grub3 commentedWhy not integrate the source code of this module into core:
http://drupal.org/project/prev_next
The code is available.
Why not use it.
Comment #11
catchThat should at least be used for AF, but I'd not heard of it until you linked to it just now.
Comment #12
grub3 commentedOkay, I am glad this feature was remove.
It was a great overhead for forums like ours.
Bye and thanks.