Download & Extend

Theming calls not handled properly

Project:Storm
Version:6.x-1.x-dev
Component:Storm.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Some calls to theme functions are called by using theme_themefunction(args) rather than theme('themefunction', args) - this means that they will not be subject to the same override behaviour etc.

Comments

#1

Status:active» fixed

Committed fixes.

Although there is a chance that there may be more of these around. All calls to theme functions must go via theme().

#2

Status:fixed» needs review

Hello @Magnity, it was the first time I'd played with theming and didn't quite understand.

I've just downloaded the latest dev and realised that we'll also need:

    'storm_link' => array(
      'file'      => 'storm.theme.inc',
      'arguments' => array(),
    ),

In the function storm_theme in storm.module or the links won't appear.

Again apologies for introducing the problem in the first place, fairly new to Drupal coding, but am keen :)

#3

Status:needs review» fixed

Committed that too for 6&7. Should have spotted that.

PS: I'd prefer you to submit the occasional bug amongst a load of features ;)

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here