Hello!

Thank you for doing this - it's totally awesome!! I was looking into writing one myself but haven't had much time and after looking into it found I would have to learn loads about Drupal so gave up.

The only thing that I found when I installed it was... it wouldn't work :(

At first I thought that it was because it was because my guild was in Europe so I tried to use an American one for a test and it still wouldn't work. It also wasn't too clear how to bring the link up (it's http://www.sitename.com/wowarmory btw).

I checked the code in wowarmory.inc and found the line:
$xml_url = "http://www.wowarmory.com/" . $page .".xml?r=" . urlencode($realm) . "&n=" . urlencode($name);

After much head scratching I noticed that there was a typo in the guild variable at the end where it should read "&gn" like so:
$xml_url = "http://www.wowarmory.com/" . $page .".xml?r=" . urlencode($realm) . "&gn=" . urlencode($name);

It is also possible to get it working with a European guild by changing the URL to the following:
$xml_url = "http://eu.wowarmory.com/" . $page .".xml?r=" . urlencode($realm) . "&gn=" . urlencode($name);

As for features I'd also like it to be able to be clickable and open a new window to the armory for whoever you click on. It would also be cool to add guild and officer comment fields where officers could write a little comment about the user similar to the ingame guild notes - this would be really handy for promotions etc.

I'll have a crack at writing some bits and upload what I do for you to look at. Feel free to bin it if you think it's rubbish ;)

Also not sure if you've seen the Drupal Lootz module? It's was written by Proffessor BikeyBike and is great for showing in game items on Drupal sites. I helped out a little bit on that one to get it to work with Wowhead.

Thanks again!

Shadowandy
http://www.heroicoutcasts.com

Comments

andy68man’s picture

andy68man commented

Just made a minor change to wowarmory.module so that each entry is clickable to open in a new window at the armory:

    $charname =  "<a href='http://eu.wowarmory.com/character-sheet.xml?r=" . variable_get('wowarmory_realm', '') . "&n=" . $member->name . "' target='_blank'>" . $member->name . "</a>";

    $rank = variable_get('wowarmory_rank_'. $member->rank, $member->rank);

    $rows[] = array($charname, $member->level, $raceimg . $member->race, $classimg . $member->class, $rank);

I've hard coded the link to the eu armory because there isn't a variable yet. Works ok though :)

nhdriver4’s picture

nhdriver4 commented

Thanks Andy. I'll look into all of this and release a new version soon.

nhdriver4’s picture

nhdriver4 commented
Assigned: Unassigned » nhdriver4
Status: Active » Fixed

New commit to the cvs. Please checkout for the latest updates.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.