Download & Extend
Paging » Issues

Create a D5 -> D6 upgrade path

Posted by webchick on August 22, 2009 at 4:14am
Project:Paging
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:webchick
Status:reviewed & tested by the community

Issue Summary

This is not a very nice "welcome to Drupal 6!" ;)

paging_filter

As you can see, <!--paging_filter--> is being displayed everywhere we're using Full/Filtered HTML. Keyz @ http://drupal.org/node/179456#comment-631446 correctly identified the cause of the error in our case: the weight of HTML corrector is later than Paging. This happens specifically in the D5 -> D6 upgrade path because it's a new filter and core sticks it at the bottom of the list.

It seems this could be readily solved by writing an upgrade path to change the weight of the Paging filter to +1 HTML corrector's weight in each input format it's found in. Patch forthcoming sometime over the weekend.

There are a few places where this has already been reported, such as #179456: <!--paging_filter--> not removed from HTML output and #433604: The garbage in displayed code, but those issues get a bit tangled up in the various ways you can get configuring input formats wrong. The scope of this issue is just fixing the upgrade path, so this specific problem doesn't bite anyone else.

Login or register to post comments

Comments

#1

Posted by webchick on August 22, 2009 at 4:16am
Assigned to:Anonymous» webchick

#2

Posted by webchick on August 23, 2009 at 6:03am
Status:active» needs review

This should get the job done.

AttachmentSize
paging-fix-d5-d6-upgrade-556334-1.patch 1.47 KB

#3

Posted by webchick on August 23, 2009 at 11:31am
Title:Re-weight Paging filter after HTML corrector in D5 -> D6 upgrade path» Create a D5 -> D6 upgrade path
Status:needs review» needs work

Oh, well this goes a bit deeper than this even. None of the content type associations are kept, either.

#4

Posted by webchick on August 23, 2009 at 12:37pm
Status:needs work» needs review

I think this should do it.

AttachmentSize
paging-fix-d5-d6-upgrade-path-556334-4.patch 2.19 KB

#5

Posted by ayalon on September 23, 2009 at 2:00pm
Status:needs review» reviewed & tested by the community

Dear webchick!

Thanks for that upgrade path code. I used #4 and it worked like a charm.

You helped me alot with this patch.

#6

Posted by webchick on September 23, 2009 at 9:34pm

Yay! :) Thanks for the RTBC, ayalon!

#7

Posted by rickauer on December 15, 2009 at 3:00pm

#4 helped me too, thanks a lot. For the sake of completeness: this patch is not yet integrated in the upstream paging module. Is it orphaned?