Create a D5 -> D6 upgrade path

webchick - August 22, 2009 - 04:14
Project:Paging
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:webchick
Status:reviewed & tested by the community
Description

This is not a very nice "welcome to Drupal 6!" ;)

paging_filter

As you can see, <!--paging_filter--> is being displayed everywhere we're using Full/Filtered HTML. Keyz @ http://drupal.org/node/179456#comment-631446 correctly identified the cause of the error in our case: the weight of HTML corrector is later than Paging. This happens specifically in the D5 -> D6 upgrade path because it's a new filter and core sticks it at the bottom of the list.

It seems this could be readily solved by writing an upgrade path to change the weight of the Paging filter to +1 HTML corrector's weight in each input format it's found in. Patch forthcoming sometime over the weekend.

There are a few places where this has already been reported, such as #179456: <!--paging_filter--> not removed from HTML output and #433604: The garbage in displayed code, but those issues get a bit tangled up in the various ways you can get configuring input formats wrong. The scope of this issue is just fixing the upgrade path, so this specific problem doesn't bite anyone else.

#1

webchick - August 22, 2009 - 04:16
Assigned to:Anonymous» webchick

#2

webchick - August 23, 2009 - 06:03
Status:active» needs review

This should get the job done.

AttachmentSize
paging-fix-d5-d6-upgrade-556334-1.patch 1.47 KB

#3

webchick - August 23, 2009 - 11:31
Title:Re-weight Paging filter after HTML corrector in D5 -> D6 upgrade path» Create a D5 -> D6 upgrade path
Status:needs review» needs work

Oh, well this goes a bit deeper than this even. None of the content type associations are kept, either.

#4

webchick - August 23, 2009 - 12:37
Status:needs work» needs review

I think this should do it.

AttachmentSize
paging-fix-d5-d6-upgrade-path-556334-4.patch 2.19 KB

#5

ayalon - September 23, 2009 - 14:00
Status:needs review» reviewed & tested by the community

Dear webchick!

Thanks for that upgrade path code. I used #4 and it worked like a charm.

You helped me alot with this patch.

#6

webchick - September 23, 2009 - 21:34

Yay! :) Thanks for the RTBC, ayalon!

 
 

Drupal is a registered trademark of Dries Buytaert.