Add text format API to manipulate formats [#556832]

There is not a real text format API to load/save/delete text formats, all the queries are executed in form submit handlers.

Install profiles could use text format APIs to add predefined formats when installing.

The patch add filter_format_save() and filter_format_delete() to filter module. The code from the submit handlers is moved to these API functions.

Related issue: #428296: Filter system doesn't communicate with modules about altered text formats. We should add the hooks proposed there inside these API functions.

Comment	File	Size	Author
#4	formats-API-4.patch	7.61 KB	dropcube
	formats-API.patch	7.84 KB	dropcube

Comments

Comment #1

dropcube commented 22 August 2009 at 22:38

This API would useful for #556838: Install profiles should install the text formats they require

Comment #2

moshe weitzman commented 24 August 2009 at 02:08

Status:

Needs review

» Reviewed & tested by the community

Nice work. We have good code coverage for this with testFilterAdmin() class so we can proceed with RTBC.

Ping me if you have a patch to start using strings for text format IDs (hint hint).

Thanks for working on our neglected text format system.

Comment #3

sun

German

Karlsruhe

commented 24 August 2009 at 03:35

Status:

Reviewed & tested by the community

» Needs work

+++ modules/filter/filter.module	22 Aug 2009 22:17:04 -0000
@@ -138,6 +138,100 @@
+ * @param $format
+ *  A format object.

Wrong indentation.

+++ modules/filter/filter.module	22 Aug 2009 22:17:04 -0000
@@ -138,6 +138,100 @@
+  $current = filter_list_format($format->format);
+  $format->name = trim($format->name);
+  $filters = $format->filters;

These lines could use some simple comments to explain what's being done.

+++ modules/filter/filter.module	22 Aug 2009 22:17:04 -0000
@@ -138,6 +138,100 @@
+  
...
+    
...
+    ->execute();  
+

(and elsewhere) Trailing white-space.

+++ modules/filter/filter.module	22 Aug 2009 22:17:04 -0000
@@ -138,6 +138,100 @@
+  // Add a new text format.
+  if (!$format->format) {

Better check using !empty().

+++ modules/filter/filter.admin.inc	22 Aug 2009 22:16:47 -0000
@@ -197,78 +197,23 @@
+    
+  switch ($status) {
+    case SAVED_NEW:
+     drupal_set_message(t('Added text format %format.', array('%format' => $format->name)));
+      $return .= '/' . $format->format;
+      break;
+    case SAVED_UPDATED:
+      drupal_set_message(t('The text format settings have been updated.'));
+      break;
+  }  
+

Wrong indentation and trailing white-space here.

I'm on crack. Are you, too?