When creating a node, you see a fieldset around summary and body. This is visually not what we want, nor how we should apply fieldsets.
The issue is to remove the body, fieldset.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 557056_removing_the_body_fieldset_6.patch | 1.83 KB | sign |
| #3 | body_fieldset_after.png | 9.47 KB | sign |
| #3 | body_fieldset_before.png | 10.67 KB | sign |
| #2 | 557056_removing_the_body_fieldset_2.patch | 1.06 KB | sign |
| #1 | fieldset.png | 9.89 KB | Bojhan |
Comments
Comment #1
Bojhan commentedComment #2
sign commentedComment #3
sign commentedBefore and after screens
Comment #4
catchThis looks great, will be even better when the collapsed summary patch gets in.
Comment #5
webchickIndentation is off for the return $element['#children']; line now that it's not nested.
I'm picky, but even I wouldn't set a patch CNW for just that, however, catch pointed out in IRC that we might not need this theme function at all anymore. Does it look the same if we remove it altogether?
Comment #6
sign commentedYes, make sense to me to remove text_textarea_with_summary themeable function as the output is same after first patch
attached a patch that also removes themeable function text_textarea_with_summary
Comment #7
catchMuch better, sorry for missing this first time around. Please wait for test bot before commit.
Comment #8
yched commentedNote that this very much related to #513414: User-Test Position of Teaser field above main text field in node form. Perhaps the appearance of this whole body / summary section should me merged into one issue ?
Comment #9
Bojhan commentedNah, its fine to fix that here.
Comment #10
webchickI went ahead and committed this. It's probably going to require a re-roll of #513414: User-Test Position of Teaser field above main text field in node form, though.