When creating a node, you see a fieldset around summary and body. This is visually not what we want, nor how we should apply fieldsets.

The issue is to remove the body, fieldset.

Comments

Bojhan’s picture

Issue tags: +Usability, +D7UX
StatusFileSize
new9.89 KB
sign’s picture

Status: Active » Needs review
StatusFileSize
new1.06 KB
sign’s picture

StatusFileSize
new10.67 KB
new9.47 KB

Before and after screens

catch’s picture

Status: Needs review » Reviewed & tested by the community

This looks great, will be even better when the collapsed summary patch gets in.

webchick’s picture

Status: Reviewed & tested by the community » Needs work

Indentation is off for the return $element['#children']; line now that it's not nested.

I'm picky, but even I wouldn't set a patch CNW for just that, however, catch pointed out in IRC that we might not need this theme function at all anymore. Does it look the same if we remove it altogether?

sign’s picture

Status: Needs work » Needs review
StatusFileSize
new1.83 KB

Yes, make sense to me to remove text_textarea_with_summary themeable function as the output is same after first patch

attached a patch that also removes themeable function text_textarea_with_summary

catch’s picture

Status: Needs review » Reviewed & tested by the community

Much better, sorry for missing this first time around. Please wait for test bot before commit.

yched’s picture

Status: Reviewed & tested by the community » Needs review

Note that this very much related to #513414: User-Test Position of Teaser field above main text field in node form. Perhaps the appearance of this whole body / summary section should me merged into one issue ?

Bojhan’s picture

Status: Needs review » Reviewed & tested by the community

Nah, its fine to fix that here.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

I went ahead and committed this. It's probably going to require a re-roll of #513414: User-Test Position of Teaser field above main text field in node form, though.

Status: Fixed » Closed (fixed)
Issue tags: -Usability, -D7UX

Automatically closed -- issue fixed for 2 weeks with no activity.