slip [slip]

Minor comment. Only had a quick lookover of the code.

Between lines 247 and 356 of the .module, you're unnecessarily using double-quoted strings compared to your use of single-quoted strings all throughout the rest of your code.

$result = db_query("SELECT * FROM {uc_order_products} WHERE order_product_id = %d", $item);

versus

$result = db_query('SELECT * FROM {uc_order_products} WHERE order_product_id = %d', $item);

Maybe fix this to keep consistency?

1. jQuery.ScrollTo should be removed; files available from third-party web site must not be added into Drupal.org CVS.
2. The CSS style should be moved from uberpos-receipt.tpl.php into a separate file.

3.   $form['search']['submit'] = array(
       '#type' => 'submit',
       '#value' => t('Save configuration'),
       '#suffix' => l(t('Cancel changes'), 'admin/store/settings/pos'),
     );
   

   Add a second submit button.

4. function uberpos_install() {
     drupal_install_schema('uberpos');
   
     $t = get_t();
    

   t() is available during installation of a module, as Drupal executes a full bootstrap, in that case.

5. See the Drupal coding standards to understand how a module code should be written.

6.     include_once(drupal_get_path('module', uc_credit) . '/uc_credit.admin.inc');
   

   There is a Drupal function to use in the case you need to load a file of another module.

7.   include_once(drupal_get_path('module', 'uberpos') . '/uberpos-login.tpl.php');
   

   That is not the way a theme template is used.

8.   $output['head'] = drupal_get_html_head();
     $output['scripts'] = drupal_get_js();
     $output['favicon'] = theme_get_setting('toggle_favicon') ? "<link rel='shortcut icon' href='". theme_get_setting('favicon') ."' type='image/x-icon' />\n" : '';
     $output['language'] = $language->language;
   
     /* Show any existing drupal system messages and require them to be cleared */
     $all_messages = drupal_get_messages();
     foreach($all_messages as $type => $messages) {
       foreach($messages as $message) {
         $_SESSION['clear_message'] .= '<div id="sys-message">' . $message . '</div>';
       }
     }
   
     $drupal_css = drupal_add_css();
   

   That is all code that belongs to a theme, not a module.

9. uberpos.tpl.php returns the output of a full HTML page that includes a Drupal form; that is not the correct way to proceed.

The module you are referring has a different purpose. The pages shown by print.module are thought to be used for printing.

In the case of your module, removing the output generated by Drupal, or third-party modules (and changing how the page is rendered) is not desired.

1.     else if ($input == 'CC') {
         $form_state['redirect'] = 'admin/store/pos/'. $order->order_id .'/cred
   it';
   

   It seems a new line character slipped in.

2.   $result = db_query('SELECT nid FROM {uc_products} WHERE model LIKE \'%s\'', $input);
   

   It would be better to use db_query("SELECT nid FROM {uc_products} WHERE model LIKE '%s'", $input).

3.     'description' => t('Log of void commands.'),
   

   Schema descriptions should not be passed to t() anymore.