Posted by alex_b on August 24, 2009 at 1:38am
| Project: | Feed Element Mapper |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
The status of a mapping can now be 'overridden' because it is a) an override of a default mapping or b) an override of a per content type mapping.
We need to resolve this naming conflict by avoiding the term override when creating per node type mappings.
Comments
#1
This naming conflict needs to be not only solved for the UI level but for the code level as well.
#2
I'd say when we're talking about per-content-type and per-node mapping, this is actually the scope of the mapping.
#3
tests are 100%
new terminology: scope for talking about the whole stuff, restrict when we want per-node mapping.
Both UI and code are fixed.
#4
I'd tweak this slightly. Why don't we do this:
--
Scope: This mapping is the standard content-type mapping. Any changes will affect all feeds with the same content-type. [Change to per node type].
Status: default (This mapping is defined in code).
--
Scope: This mapping is specific to this feed node. [Use standard content-type mapping]
Status: overridden (There is a default mapping defined in code but it is overridden in the database).
--
Status: normal (This mapping is defined in the database).
--
Rename _feedapi_mapper_is_overridden() to _feedapi_mapper_is_per_content_type().
#5
"Rename _feedapi_mapper_is_overridden() to _feedapi_mapper_is_per_content_type()."
_feedapi_mapper_is_overridden() even does not exists anymore. It is called _feedapi_mapper_scope() in #3
As i see you like "scope" in general, so that function name should be okay if we use scope in the UI
#6
"[Change to per node type]" - per node type is misleading, because it's rather similar to content type. People usually mix "node type" and "content type" phrases, so i'd say [Change to per node] instead.
#7
UI text is improved a little bit according to #4 (but without the "node type" phrase)
#8
Committed with some text tweaks and UI tweaks. Also updated tests. Thank you.
#9
Automatically closed -- issue fixed for 2 weeks with no activity.