"Override" per content-type mapping does not work when no mapping defined
alex_b - August 24, 2009 - 01:49
| Project: | Feed Element Mapper |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | needs review |
Description
When trying to click 'override' on a node with no content type mapping defined, 'override' does not work.
#1
There is also another problem: you have per-node mapping, you start deleting the entries and when it becomes empty, it suddenly becomes per-content-type.
Both of these issues are fixed in the patch. Conflicts with #557500: Resolve naming conflict "override per content type setting" and "override default". Tests are 100%
Also, with this patch, finally there is only one ctools_export_load_object() call in the whole .module file. This is the icing on the cake :)
#2
Should we commit #557500: Resolve naming conflict "override per content type setting" and "override default" first and then mature this patch?
#3
#2: mature this patch? This patch is fine, as i told, it conflicts w/ that patch, but it's only because of naming changes. Of course, it needs to be rerolled after #557500: Resolve naming conflict "override per content type setting" and "override default" is in.
#4
Updated after #557500: Resolve naming conflict "override per content type setting" and "override default" landed.
'per_node_placeholder' - shouldn't we introduce a general empty flag? E. g. 'NOMAPPING'?