Fallbacks for blank from address do not work

John Morahan - August 24, 2009 - 10:04
Project:SMTP Authentication Support
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Description

<?php
if ($from = variable_get('smtp_from', '') == '') {
?>

the == has higher precedence so you are really just assigning a boolean value to $from

AttachmentSize
smtp-from-blank-fallback.patch979 bytes

#1

jdwfly - September 11, 2009 - 20:08

Patch rolled fine for me.

 
 

Drupal is a registered trademark of Dries Buytaert.