if ($from = variable_get('smtp_from', '') == '') {
the == has higher precedence so you are really just assigning a boolean value to $from

CommentFileSizeAuthor
smtp-from-blank-fallback.patch979 bytesjohn morahan

Comments

jdwfly’s picture

jdwfly commented

Patch rolled fine for me.

simon georges’s picture

simon georges commented
Status: Needs review » Reviewed & tested by the community

Confirmed.

wundo’s picture

wundo commented
Status: Reviewed & tested by the community » Fixed

That has been already fixed by someone else.
Closing this. Thanks guys.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.