Dear Mr,
Using locally with easyphp, when I try to configure the number of displaying items or files, a message appears:
Please enter a numeric value.
Of course, I have entered a numeric value, but does not function.
Sincerely

CommentFileSizeAuthor
#5 workspace.diff_0.txt298 byteshutch
#3 workspace1.diff.txt2.22 KBhutch
#1 workspace.diff.txt984 byteshutch

Comments

hutch’s picture

hutch commented
StatusFileSize
new workspace.diff.txt984 bytes

The attache diff will fix it, it saves ok, but throws up the following:

warning: urlencode() expects parameter 1 to be string, object given in /home/hutch/www/drupal-4.7.0-rc3/includes/common.inc on line 1282.

I chased around common.inc, but could not see where in workspace.module the error was coming from, and as it does save correctly
that will have to do for now.

jvandyk’s picture

jvandyk commented
Status: Active » Fixed

Commited. Thanks.

hutch’s picture

hutch commented
StatusFileSize
new workspace1.diff.txt2.22 KB

Another patch.
This is on the original, so it includes the stuff I submitted on 22 April. It fixes the urlencode error by returning the
workspace_configure_submit function properly back to the workspace page, with an informative message.
It also repairs a bug in the paging, which was not setting up $count_sql properly for the first table on the workspace page.
This was done on MySQL - 4.0.24_Debian-10sarge1-log.
I do not know how this will behave on other versions of mysql ATM, if I get a chance I will test on 4.1.11
probably tomorrow although I doubt if there will be any problems.

HTH

jvandyk’s picture

jvandyk commented

Committed some parts of the patch by hutch.

hutch’s picture

hutch commented
StatusFileSize
new workspace.diff_0.txt298 bytes

Many thanks, this is a big improvement.
One small point, the submit button 'Add new item' has no css,
the attached diff fixes this.
This is on
workspace.module,v 1.21.2.7 2006/05/07 19:44:00 jvandyk

HTH

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)