Similar to (ubercart 2.x-rc6 support? #3) when applying patch as described on module home page :

"For Ubercart 6.x-2.0-rc4 onwards, use uc_vat 6.x-1.x-dev. You will also need to apply the tax line alter patch to Ubercart in order for the checkout page to work correctly - without this, the order preview pane and cart block will incorrectly apply VAT twice."

When applying said patch to ubercart rc6 I get :

patching file uc_taxes/uc_taxes.js
Hunk #1 succeeded at 5 with fuzz 2.
Hunk #2 FAILED at 31.
1 out of 3 hunks FAILED -- saving rejects to file uc_taxes/uc_taxes.js.rej

Needless to say the patch did not work.... any suggestions for where this is going wrong - or even better can anyone definatively say they got this patch to work for ubercart rc6?

Thanks

Comments

rupat’s picture

Hi the same here !

Looked at the rej file, tried to manually patch the file, but the whole package dont work.
I can make all settings for vat, but for example no price including vat appears in product page.

Would be great if someone can give us a tip.
But i will get deeper into the code tomorow, maybe i understand the patch so i can fix it by myself.

Greetings Robert !

rsvelko’s picture

subscribing. Come on, action :)

cronix’s picture

subscribing

siliconmind’s picture

subscribing

bbunse’s picture

subscribing

Need rc6 support :-/

longwave’s picture

Status: Active » Fixed

Island Usurper has produced a new patch which should fix these issues:

http://drupal.org/files/issues/518916_tax_line_alter_1_0.patch

If anyone else applies and tests this successfully, please post your comments at http://drupal.org/node/518916#comment-1993988

longwave’s picture

Alternatively, a pre-patched version of Ubercart 6.x-2.0-rc6 is available at http://www.longwaveconsulting.com/files/ubercart-6.x-2.0-rc6-patched.tar.gz

cronix’s picture

Why it this patch not included in the normal distribution? Does the patch not work for non European VAT?

longwave’s picture

The patch was originally larger than this, but only part of it was rolled into the Ubercart rc4 release, and only myself and xibun have stepped forward to test it since then - and I really haven't had as much time to look at it as I would like. Without uc_vat installed, the original and patched versions of Ubercart should function exactly the same.

Even with the patch applied there seem to be some problems post-checkout with line items and VAT calculations, I am trying to find time to work on fixing this but any further input from anyone else is more than welcome!

siliconmind’s picture

Longwave, I am seriously interested in European VAT support. I think I could help a bit. Can you describe in detail what is the problem with VAT calculations? I'll take a look at your module and see if I can help. This stuff needs sorting out because no EU VAT means no ubercart in Europe. And I like drupal a need solid eCommerce platform :)

longwave’s picture

The most recent VAT support patch for Ubercart was introduced and discussed at http://drupal.org/node/518916#comment-1967384 if you'd like to try and follow the latest developments.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.