This patch implements the hook_field_access() hook in CCK. In version 2.5 of CCK, the node object being operated on is provided as an argument to this hook function specifically for modules like CCK Field Privacy.

This removes the need for all other CCK or Views related code or hacks to handle viewing of fields in these various contexts, because that functionality is now handled through CCK's native integration automatically. This results in a massive cleanup of code and the side effect of implementing Panels integration. It will also resolve a number of other issues in the queue, virtually anything dealing with integration with another module like Content Profile, Views, or Panels.

Some specifics:

  • hook_nodeapi() is gone.
  • _cck_field_privacy_access_check() hook is gone.
  • cck_field_privacy.views.inc is unneeded and is now gone as well.

The patch is rolled against cck_field_privacy-6.x-1.x-dev on August 17th. There is some oddness in how SVN diff chose to insert the changes due to the sheer quantity of code I removed, but it should be fine.

CommentFileSizeAuthor
#8 cck_field_privacy-558210.patch13.09 KBsarhugo
cck-field-privacy-access.patch12.84 KBCPyle

Comments

CPyle’s picture

CPyle commented
Status: Active » Needs review
CPyle’s picture

CPyle commented

Issues from the active queue that are affected by this patch:

bloto’s picture

bloto commented

This patch has bugs at least for user_relationships:

First for me permission wasn't array but : a:1:{i:0;s:8:"everyone";}

1)
$permissions_arr=unserialize($permissions->permission);
if (is_array($permissions_arr))
foreach ($permissions_arr as $perm) {

2)perm is not a name of module!
$plugin_access_result = module_invoke('user_relationships_api', 'cck_field_privacy_access', $node_user, $user);

3)
and
if ($plugin_access_result === FALSE) {

should be
if ($plugin_access_result == FALSE) {

After applying these fixes it seems to work now with user_relationships.

Regards,
Tomasz

mattlc’s picture

mattlc commented

subcribing, much more logical than nodeapi and lighter...

For UR integration, why did you use plural_name as key for the form and permission instead of rtid ?
(May no be stabe a long time.)

CPyle’s picture

CPyle commented

I changed nothing in this patch related to user relationships integration. The code both of you are referring to was very recently committed and comes from #377950: Integration of CCK_field_privacy with user_relationship_module . You should probably give them your reports there to look at, as it's still an in-progress feature. I appreciate your testing, though.

sarhugo’s picture

sarhugo commented

Tested (with the #3 fixes) and working fine with user_relationships

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

The problem with the proposed patch is the compatibility with older versions of CCK. There are still 38,000 sites using a version of CCK older than 6.x-2.5.
Maybe, it would make more sense to create a branch 6.x-2 that would use the features present in branch 6.x-2 of CCK.

sarhugo’s picture

sarhugo commented
StatusFileSize
new cck_field_privacy-558210.patch13.09 KB

Attached updated patch, making cck_field_privacy_access hook called to all modules (not just UR)

vlad.k’s picture

vlad.k commented

This patch works for me. I have an profile page built with Content Profile, Panles and APK. My configuration:

CCK 6.x-2.6
Content Profile 6.x-1.0-beta4
Content Field Privacy 6.x-1.x-dev
Chaos tools 6.x-1.3
Panels 6.x-3.3

Keep up the good work!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

I am closing this issue, which is for a not supported Drupal version.