Closed (fixed)
Project:
jQZoom
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
24 Aug 2009 at 20:25 UTC
Updated:
18 Aug 2010 at 02:10 UTC
Hi, please investigate why the drupal 6 version of jqzoom gives a script error in IE7.
Comments
Comment #1
tseven commentedThe problem is the extra comma at the end of the variable definition:
Notice the comma after 340, that's what ie7 doesn't like.
I've come up with a quick and dirty hack to remove the comma.
In jqzoom.module find
$option_string .= '}; ';and place
$option_string = substr($option_string, 0, strlen($option_string)-2) . ' ';above it.
This will cut off the ending comma, and add the space back in at the end. If I weren't in the middle of a time-sensitive project I'd rewrite the original function so the comma doesn't exist in the first place... but for now this will have to do.
Comment #2
selinav commentedHello,
Nice module!
In IE7 and IE6, I've neither a loading message nor a box with the zoom.
I've tried to patch with you code above but when I do it, it doesn't work in all navigators.
Thanks in advance for your help
//edit ////////////////
I'm not correctly read, I've read "under" instead of "above".
Comment #3
mandclu commentedI also had the issue with errors thrown by IE. The fix in IE does successfully fix. Personally I'd consider it a more elegant solution to put the parameter/value strings into an array and then use an implode function, but this way gets the job done.
Comment #4
matt v. commentedI just committed a fix more along the lines of what surge_martin suggested. Thanks everyone for help in finding and suggesting fixes for the issue!