system_performance_settings is rendered by system_settings_form. It also has a submit button which value (#value => t('Clear all caches')) is saved as a variable to (variable_set). This variable is just has no meaning and just clutters the variable table. This patch unsets $form_state['values']['clear'] on _validate.

CommentFileSizeAuthor
remove-clear-variable.patch1.07 KBdavyvdb

Comments

davyvdb’s picture

davyvdb commented
Issue tags: +Quick fix, +Cleanup

tagging

c960657’s picture

c960657 commented

system_settings_form_submit() already contains a list of values to ignore. Would it be better to add it there? Or even better - make that function ignore #type == "button".

c960657’s picture

c960657 commented

See also #594650: Provide central $form_state['values'] clearance.

c960657’s picture

c960657 commented
Status: Needs review » Fixed

Looks like this problem was fixed by the clean-up function added in #594650: Provide central $form_state['values'] clearance.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix, -Cleanup

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix, +

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Issue tags: -Quick fix, -Cleanup +API clean-up