User login and register forms broken on multilingual sites

It looks like Lyle already committed a patch for this. Not sure why we need an issue after the fact. : ?

Does that patch not solve it for you?

On our site, the login form's action points to /nl/nl/user which is probably a related problem. The attached patch calls url() with the 'external' option and skips the substr() call, it works for us.

great! had the same problem - now fixed. thanks!

the following might be interesting to reproduce the problem:
until now I had two workarounds - hoping to fix it later... depending on what I was working on I had either the "Cart" module disabled in "Ubercart - core" or I had to set the "User login" block to block type Standard. both fixed the problem. but having either the Cart module enabled OR the user login block of type "Link" both made it impossible to login on my site.

I also had the problem reported by wimh in #3, and I can confirm the patch fixes this.

1. I'm attaching a new patch with a cosmetic change (I've removed some comments that are now meaningless). The actual code change are exactly the same as that of wimh ;
2. I'm marking this as 'reviewed by the comunity' since two people confirmed it works, and I think the code change are sensible

Thanks for Ubercart everyone, and thanks wimh for this patch :)

Hasn't this already been fixed in a much cleaner way by Damien Tournord in #561210: uc_cart_form_alter() is ugly and broken?

@longwave: It looks like it might, I would have to test the patch.

Unfortunately I didn't find Damien Tournord's patch when searching for this, as the symptoms he describes are different.

I'll try to find a minute to test his patch, though probably not today.

I have downloaded and tested the UC dev snapshot from bazaar.ubercart.org which includes Damien Tournord's patch (see #6).

I can confirm that on my site the problem is fixed by #561210: uc_cart_form_alter() is ugly and broken and therefor the patch presented in this issue is not necessary anymore in my case.

Anslem, if you find the same results as xibun in your testing, can you mark this one fixed?