Download & Extend
Scheduler » Issues

Code style cleanup

Posted by deekayen on August 24, 2009 at 11:03pm
Project:Scheduler
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I processed the source with Coder and updated the layout of the .install file.

The highlights: It removes the obsolete hook_help() that was used before .info files provided the module description on the modules page, switches update functions to use schema api, removes trailing whitespaces, and adds @file docblocks according to webchick's guidelines in #263956: Ye Grande Olde Drupal 7 .install File Cleanup.

AttachmentSize
scheduler_code_style.patch18.02 KB
Login or register to post comments

Comments

#1

Posted by Eric Schaefer on August 25, 2009 at 7:36pm

Looks good to me. Did you test the update functions?

#2

Posted by deekayen on August 25, 2009 at 8:03pm

no

#3

Posted by Eric Schaefer on August 26, 2009 at 5:42pm
Status:needs review» fixed

http://drupal.org/cvs?commit=256408

Thanks.

#4

Posted by Eric Schaefer on August 26, 2009 at 5:42pm

BTW: The update works...

#5

Posted by System Message on September 9, 2009 at 5:50pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.