Upcoming patch prevents tasks such as 'Delete', 'Restore', 'Migrate' from being performed on the 'special' main aegir site, since it is now a regular site inside /sites/

It leaves tasks 'Backup', 'Verify' and 'Enable' as safe tasks (Disabled is not safe on the main site, as it could introduce issues that I haven't been brave enough to test :) such as rewrite of the main aegir site to a subdirectory of itself, inability to access the frontend to re-enable, etc.. this may need further thought / discussion)

Thanks anarcat for untwisting my bad logic getting this into what is a rather bizarre access function :)

CommentFileSizeAuthor
#3 558608.patch1.14 KBmig5
#1 558608.patch1.13 KBmig5

Comments

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new 558608.patch1.13 KB

attached

anarcat’s picture

anarcat commented
Priority: Normal » Critical

This is a requirement for 0.3 now that we actively suggest people stop using the hidden 'default' site in INSTALL.txt (#453540: consider the 'default' site like a regular site, with exceptions is still 'needs work' though), so marking as critical.

Patch is pretty much what i expected even though whitespace is a bit odd.

I would add that upgrades with sites outside of sites/default are something that dearly needs testing in 0.3, but that's offtopic here.

I'll try to test all this tomorrow or at least do one test run before the final release.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new 558608.patch1.14 KB

Sorry, reroll attached with the correct indentation. Dunno how I missed it.

adrian’s picture

adrian commented
Status: Needs review » Fixed

committed. thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.