Download & Extend
Pirate » Issues

Release Drupal 7 version of Pirate

Posted by sillygwailo on August 25, 2009 at 3:51pm
Project:Pirate
Version:7.x-1.x-dev
Component:Code
Category:task
Priority:critical
Assigned:sillygwailo
Status:closed (fixed)

Issue Summary

A developmental branch is available as of today. If you find any Drupal 7 compatibility issues, post them here.

Login or register to post comments

Comments

#1

Posted by sun on September 19, 2010 at 8:22pm
Priority:normal» critical
Status:active» needs review

See #310812: Pirates in Drupal

AttachmentSize
pirate-DRUPAL-7--1.render.1.patch 5.25 KB

#2

Posted by sun on September 19, 2010 at 8:29pm

piratized.png

AttachmentSize
piratized.png 5.13 KB

#3

Posted by sun on September 19, 2010 at 8:47pm

piratized.modules.png

AttachmentSize
piratized.modules.png 16.81 KB

#4

Posted by sillygwailo on September 19, 2010 at 9:05pm
Status:needs review» active

Committed. Keepin' th' issue open until D7 be released officially. Yarr!

#5

Posted by Damien Tournoud on September 20, 2010 at 5:32am

Usin' the /e modifier is greatly grandly discouraged, Scurvy dog!

<?php
-    '/(\.\s)/e' => 'avast("$0",3)',
-    /([!
?>
\s)/e' => 'avast("$0",2)', // Greater chance after exclamation
+ '/(\.\s)/e' => 'pirate_avast("$0",3)',
+ '/([!\?]\s)/e' => 'pirate_avast("$0",2)', // Greater chance after exclamation
?>

It ain't because you be a pirate that you shouldn't be security conscious.

#6

Posted by sun on September 20, 2010 at 3:49pm

Dang. I knew there was something, when I starred at that code, and resorted to only fix the function namespace...

#7

Posted by sillygwailo on September 20, 2010 at 5:24pm
Status:active» closed (fixed)

Made a separate issue for that at #917254: Remove /e modifier in preg_replace. Now that the 7.x-dev release is a little more stable, let's file separate issues for that branch.