In _feedapi_call_parsers() the module_invoke for secondary parsers passes FALSE instead of the parser's settings array, as done for the primary parser. This appears to be a simple oversight, perhaps due to previous feedapi api changes I am unaware of. Here's a patch, please review.

CommentFileSizeAuthor
feedapi-secondary_parser_settings.patch793 bytescedarm

Comments

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs review » Reviewed & tested by the community

Thank you, this is a good catch!
May i ask you that what is the use-case for the secondary parser? The majority of FeedAPI installations use one parser.

cedarm’s picture

cedarm commented

We have a feed that will only supply numeric tag ids and not human readable tags. But the service does have an API we can call to get the mapping of tag id to text, as well as the "parent tag id". Our secondary parser has a setting to specify which parent ids to treat as a vocabulary, so the output of the parser can give more than one array of tags. These can then be mapped (with feedapi_mapper) to different Drupal vocabularies.

(And, since we now have the secondary parser, we threw in our own raw mapping of our namespaced tags, until #199360: Add namespace support to Parser Common Syndication and #552092: Add namespace support to Parser SimplePie can be resolved. But we'll likely just leave it there so we don't have to redo our mappings.)

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Reviewed & tested by the community » Fixed

committed, thank you

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.