Download & Extend
Feed Element Mapper » Issues

_feedapi_parse() doesn't pass settings to _feedapi_call_parsers()

Posted by cedarm on August 25, 2009 at 6:33pm
Project:Feed Element Mapper
Version:6.x-1.0
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

This is related to #559242: settings not passed to secondary parsers.

Not sure what has happened in the past with the parameters for _feedapi_call_parsers(). The third parameter is supposed to be $settings, but instead we call it with $feed->half_done ? FALSE : TRUE.

Here's a patch according to my understanding. It works with my secondary parser, along with the other patch from #559242: settings not passed to secondary parsers.

AttachmentSize
feedapi_mapper-parser_settings.patch532 bytes
Login or register to post comments

Comments

#1

Posted by Aron Novak on August 25, 2009 at 6:51pm
Status:needs review» reviewed & tested by the community

Again, good catch!
This issue is valid for 2.x branch also, unfortunately.

#2

Posted by Aron Novak on November 13, 2009 at 8:22pm
Status:reviewed & tested by the community» fixed

Committed for both 1.x and 2.x.
Sorry for doing this so lately.

#3

Posted by System Message on November 27, 2009 at 8:30pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.