The jQuery currency conversion dialog can only be invoked once per page load
adrinux - August 25, 2009 - 20:22
| Project: | Money CCK field |
| Version: | 6.x-1.2 |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
It seems the currency conversion dialog can only be opened once per page load, it work as expected the first time, but if you then close the pop-up dialog the launch button no longer has any effect. There are no js errors reported in either Firefox 3.5 or Safari 4.
#1
Oh, I see. Could you please try with the following mini-patch to
money_conversion_dialog.js?- close: function () { acdb.cancel(); },- width: '450px', height: '200px',
+ close: function () {
+ acdb.cancel();
+ $('#money-conversion-dialog').dialog('destroy');
+ $('#money-conversion-form').remove();
+ },
+ width: 450, height: 250,
#2
Yes, that does the trick, thanks!
Attached, in patch form, with the height tweaked to 156.
#3
Committed an slight variation of this (patch). You can now override the dialog size (in pixels) in your theme. All you need to do it provide a .js file with your customization of the following:
/*** Allow themers override the modal dialog size (in pixels).
*/
Drupal.theme.prototype.moneyConversionDialogSize = function() {
return {width: 450, height: 250};
};
#4
Just installed this module and discovered the same hickup. Glad to have found this! Could anybody just explain how do I "patch" that .js file, what does it mean? Is there an easy way, like copying the patch lines and pasting it in the last line when code edit money_conversion_dialog.js?
#5
@dark.o: If you ever need it, just read: http://drupal.org/patch/apply
Anyway, you can get the dev release of money module to get this fix as I already committed the patch to CVS.
#6
thank you man... I was trying to make it work with eclipse, but it did not behave as in instructions, and me coming from another world (not programing) made in no easier. However, I will use dev version of your module! thnx again for fast reply!
#7
Just tried it and it does not work for me. I do get up the pop up window to open without reloading the page... however in the popup window (second time I run in on the same page load) there is no select list to choose currencies from. Is it the bug, or just something I did wrong? I did run update, after deleting and installing the .dev version of the module.
#8
Maybe it was a browser cache issue with the .js file.
Also, make sure you have a version of jQuery UI that is compatible with your version of jQuery. Drupal 6 comes with jQuery 1.2.6, and this is compatible with jQuery UI 1.6.x. On the other hand, jQuery UI 1.7.x requires jQuery 1.3.x which is provided by jQuery Update module.
Other than that, no sure what else it could be...
#9
... deleted my previous post, was confusing, even for me... yes all versions are matching eachother. (1.2.6, -> 1.6) tested on different browsers, different versions of jquery_ui, running now .dev version but it doesn´t help... still no sellect list upon second invoke, under same page load
actually, to me it looks like as it just shows the pop up window... but there is no load of any data. that little circle inside the pop up, indicating some action is missing
#10
Automatically closed -- issue fixed for 2 weeks with no activity.
#11
Same problem.
Installed the latest dev version and now I can open the lightbox multiple times but after the first time, no currency select box appears.
#12
Opening this issue again.
It's a problem that makes this option almost unusable.
I have several currency amounts listed on one page and the user will be sure to click them all to convert.
#13
That's just a symptom of something that does not work as expected, however how do yo know this module is at fault?
It works for me (several browsers).
#14
Back to closed state.
@druplicate: Please, open a separate issue with as much information as possible to reproduce the problem. Otherwise, it is not possible to guess what's going on, so we won't be able to do nothing about it. It could be related to another module, it could related to non-compatible versions of jQuery, jQuery UI, ...