The jQuery currency conversion dialog can only be invoked once per page load

Oh, I see. Could you please try with the following mini-patch to money_conversion_dialog.js?

-        close: function () { acdb.cancel(); },
-        width: '450px', height: '200px',
+        close: function () {
+          acdb.cancel();
+          $('#money-conversion-dialog').dialog('destroy');
+          $('#money-conversion-form').remove();
+        },
+        width: 450, height: 250,

Committed an slight variation of this (patch). You can now override the dialog size (in pixels) in your theme. All you need to do it provide a .js file with your customization of the following:

/**
 * Allow themers override the modal dialog size (in pixels).
 */
Drupal.theme.prototype.moneyConversionDialogSize = function() {
  return {width: 450, height: 250};
};

Just installed this module and discovered the same hickup. Glad to have found this! Could anybody just explain how do I "patch" that .js file, what does it mean? Is there an easy way, like copying the patch lines and pasting it in the last line when code edit money_conversion_dialog.js?

@dark.o: If you ever need it, just read: http://drupal.org/patch/apply

Anyway, you can get the dev release of money module to get this fix as I already committed the patch to CVS.

thank you man... I was trying to make it work with eclipse, but it did not behave as in instructions, and me coming from another world (not programing) made in no easier. However, I will use dev version of your module! thnx again for fast reply!

Just tried it and it does not work for me. I do get up the pop up window to open without reloading the page... however in the popup window (second time I run in on the same page load) there is no select list to choose currencies from. Is it the bug, or just something I did wrong? I did run update, after deleting and installing the .dev version of the module.

Maybe it was a browser cache issue with the .js file.

Also, make sure you have a version of jQuery UI that is compatible with your version of jQuery. Drupal 6 comes with jQuery 1.2.6, and this is compatible with jQuery UI 1.6.x. On the other hand, jQuery UI 1.7.x requires jQuery 1.3.x which is provided by jQuery Update module.

Other than that, no sure what else it could be...

... deleted my previous post, was confusing, even for me... yes all versions are matching eachother. (1.2.6, -> 1.6) tested on different browsers, different versions of jquery_ui, running now .dev version but it doesn´t help... still no sellect list upon second invoke, under same page load

actually, to me it looks like as it just shows the pop up window... but there is no load of any data. that little circle inside the pop up, indicating some action is missing

Same problem.

Installed the latest dev version and now I can open the lightbox multiple times but after the first time, no currency select box appears.

Opening this issue again.

It's a problem that makes this option almost unusable.

I have several currency amounts listed on one page and the user will be sure to click them all to convert.

That's just a symptom of something that does not work as expected, however how do yo know this module is at fault?

It works for me (several browsers).

Back to closed state.

@druplicate: Please, open a separate issue with as much information as possible to reproduce the problem. Otherwise, it is not possible to guess what's going on, so we won't be able to do nothing about it. It could be related to another module, it could related to non-compatible versions of jQuery, jQuery UI, ...

Why open a new issue since it's the very same issue and I'm not the only one with this problem, so it would be nice if others could maintain continuity and track this from the beginning.

I have a feeling there aren't many using this feature as it's not mentioned on the project page anywhere I can see. Perhaps you should tout it so that more will try it and we can solve this issue faster.

Just to clarify - I get the pop up box on 2nd invoke but it contains empty white space and the blue header with the currency amount to be converted, and the close button.

Tested in FF3.5.7, IE8, Opera10.10

Using:
jQuery UI 1.6
jQuery Update 1.2.6
System and all modules up to date.

What modules might be likely to interfere?

I disabled three known sources of js on the offending page but they had no effect (CCK fieldset accordion, ddblock, views slideshow).

I'm outputing the field as: <td id="pcol-4"><?php print $node->field_sales_price[0]['view'];?></td>

I have 2 fields like this on the same page and clicking either one for the 2nd invoke results in the problem.

Apparently the patch you issued solved the problem for one person, so it's likely related, but something else is causing the patch not to work for me. Not sure what that would be.

I know nothing about javascript, so don't know how to step through the code using Firebug, but if you could point me in the right direction I might figure it out.

Here are the scripts loaded for this page (no cache turned on):

<script type="text/javascript" src="/sites/all/modules/jquery_update/replace/jquery.min.js?r"></script>
<script type="text/javascript" src="/misc/drupal.js?r"></script>
<script type="text/javascript" src="/sites/all/modules/l10n_client/jquery.hotkeys.js?r"></script>
<script type="text/javascript" src="/sites/all/modules/l10n_client/jquery.cookie.js?r"></script>
<script type="text/javascript" src="/sites/all/modules/l10n_client/l10n_client.js?r"></script>
<script type="text/javascript" src="/misc/textarea.js?r"></script>
<script type="text/javascript" src="/sites/all/modules/poormanscron/poormanscron.js?r"></script>
<script type="text/javascript" src="/sites/all/modules/nodequeue/nodequeue.js?r"></script>
<script type="text/javascript" src="/modules/acquia/jquery_ui/jquery.ui/ui/minified/ui.core.min.js?r"></script>
<script type="text/javascript" src="/modules/acquia/jquery_ui/jquery.ui/ui/minified/ui.dialog.min.js?r"></script>
<script type="text/javascript" src="/modules/acquia/jquery_ui/jquery.ui/ui/minified/ui.draggable.min.js?r"></script>
<script type="text/javascript" src="/misc/autocomplete.js?r"></script>
<script type="text/javascript" src="/sites/all/modules/money/modules/money_conversion_dialog/money_conversion_dialog.js?r"></script>
<script type="text/javascript" src="/misc/collapse.js?r"></script>
<script type="text/javascript" src="/sites/all/modules/ddblock/js/jquery.cycle.all.min.js?r"></script>
<script type="text/javascript" src="/sites/all/modules/ddblock/js/jquery.easing.1.1.1.js?r"></script>
<script type="text/javascript" src="/sites/all/modules/ddblock/js/json2.pack.js?r"></script>
<script type="text/javascript" src="/sites/all/modules/ddblock/js/ddblock.js?r"></script>
<script type="text/javascript" src="/sites/all/modules/flag/theme/flag.js?r"></script>
<script type="text/javascript" src="/sites/all/modules/views_slideshow/contrib/views_slideshow_singleframe/views_slideshow.js?r"></script>
<script type="text/javascript" src="/sites/all/modules/views_slideshow/js/jquery.cycle.all.min.js?r"></script>
<script type="text/javascript" src="/sites/all/themes/fusion/fusion_core/js/jquery.bgiframe.min.js?r"></script>
<script type="text/javascript" src="/sites/all/themes/fusion/fusion_core/js/hoverIntent.js?r"></script>
<script type="text/javascript" src="/sites/all/themes/fusion/fusion_core/js/supposition.js?r"></script>
<script type="text/javascript" src="/sites/all/themes/fusion/fusion_core/js/supersubs.js?r"></script>
<script type="text/javascript" src="/sites/all/themes/fusion/fusion_core/js/superfish.js?r"></script>
<script type="text/javascript" src="/sites/all/themes/fusion/fusion_core/js/screenshot.js?r"></script>
<script type="text/javascript" src="/sites/all/themes/fusion/fusion_core/js/script.js?r"></script>
<script type="text/javascript" src="/sites/all/themes/acquia_marina/js/jquery.corner.js?r"></script>
<script type="text/javascript" src="/sites/all/themes/acquia_marina/js/acquia-marina-script.js?r"></script>
<script type="text/javascript" src="/sites/all/themes/fusion/fusion_core/js/jquery.overlabel.js?r"></script>
<script type="text/javascript">

Try with default node template, and/or try with Garland. Maybe it is related to that.

Also, try with jQuery 1.3.x (needs jquery_update module) and jQuery UI 1.7.x. Maybe that makes a difference.

Aside from testing #16...

- Try with latest dev snapshot of this module.
- Any javascript error on the page?
- Can you try on a plain installation with just the modules required to run this feature?

It works here, so I cannot really tell what's going on... this may need on site debugging, firebug, etc.

I am having the same problem as druplicate at #15, if you have figured out what the problem was please post the solution. Much appreciated!

Tried with Garland and stock template - same problem.

Already using the dev version from last August.

A while ago I was using Firebug to try and see what was happening and I used some mode where I could observe the javascript in action, but for the life of me I can't figure out how I did that. But I do remember seeing on the 2nd invoke, no response from the server, or something like that.

How can I use FB to diagnose this, in three easy steps? ;-)

Oh, I reported the javascript error here but forgot about it: http://drupal.org/node/623810

The site is now live if you care to have a look at this page and try it for yourself - maybe you can debug it too.

http://bangkokcondoandhouse.com/en/content/property-id-426

The site is locked down while under development to keep out crawlers.

user: guest
pswd: LoS31756#

It's still hard to tell because the site is using js aggregation.

Anyway, opening the .js file, it looks like the site is using the jQuery library as shipped with Drupal 6, and this could be the problem. See #16

On my test server I upgraded jquery:

jQuery UI 1.7.3
jQuery Update 1.3.2 (6.x-2.x-dev)

Now on second invoke I get no response at all - no popup.

Then I turned off jquery aggregation on the test server and now it works! Javascript compression on the performance page was already off.

I hadn't heretofore realized that jQuery aggregation is a separate process from javascript compression, so never tried that option.

Note that there were some warnings when I performed update.php for jQuery Update. Maybe should have used the 6.x-2.x-alpha1 version.

On the live server I turned off jquery aggregation and then javascript compression (performance page) as well and it still didn't work using:

jQuery UI 1.6
jQuery Update 1.2.6

Compression is still off on the live server if that helps you debug this, though it sounds to me like you are requiring the upgrade - not sure if anyone has this working without upgrading.

So you can get this to work by upgrading jQuery and turning off jQuery compression, but that's not good if you want your site to be quick.

EDIT: Updated to jQuery Update 6.x-2.x-alpha1, turned on aggregation and it still works - no update.php errors either. Then turned on javascript compression and everything is fine - problem solved - thanks for the help!

EDIT2:Went to update the live server and encountered the same update.php warnings using the alpha version. So just repeated update.php and everything worked in the end.

I think you can simply ignore those warnings while upgrading jQuery Update, they could have been caused by #443718: PHP notices in update.php due to jquery_update_update_6200() not returning array.

As per the [EDIT] notes, it seems upgrading fixed the problem. So I have updated the project page to add a note about this jQuery Update 6.x-2.x requirement.

I updated the patch by adding the code, and it fixed the problem, but not completely.
Now the dialog opens again, but the inner form is not shown (to: currency select box).

Same problem when installing the latest dev version - 6.x-1.x-dev

How can I solve it?
Thanks in advance.

Hello,

Same issue here: The jQuery currency conversion dialog can only be invoked once per page load.

Using:
jQuery UI 1.7.3 (6.x-1.3)
jQuery Update 1.3.2 (6.x-2.0-alpha1)
System and all modules up to date.
CSS and Javascript optimization (in settings/performance) turned off.

Tested with Clean theme and Garland.

There must be something I'm missing, thanks in advance for your ideas ! :)

Edit: Ok, I missed the patch in #2 and or the dev version... Everything seems functional now.