Closed (fixed)
Project:
Advanced Forum
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
25 Aug 2009 at 20:38 UTC
Updated:
22 Sep 2009 at 19:20 UTC
Since the panels integration lives inside advanced forum, I'm posting this here. I'm currently using the 6.x-2.x-dev (2009-Jul-30) version of advanced forum. I know it's older, but we've been holding off on upgrading it, in the hopes that this will see a beta version soon. It's been pretty stable for us.
The problem is this: in Panels, we have custom pages for things like 'forum/active' and 'forum/unanswered' and these are working fine. I'd like to add a forum context to these, though, so that we can include some of the forum-related links that are available in the system forum/% override. When I try to add the Forum contexts, I get the error you see in the screenshot below (sorry, can't copy/paste the error out of the system dialog, and it's not a particularly helpful error message. But it's all I've got.) When this error appears and I dismiss it, the panels pop-up dialog for editing the context just stays white, until I close the pop-up. So, I'm never able to set a context.
Any idea on what this might be? is it a known issue that has been fixed since the version we're running now? I couldn't find anything in the change log that addresses this specifically.
| Comment | File | Size | Author |
|---|---|---|---|
| Picture 3.png | 22.4 KB | friolator |
Comments
Comment #1
michelleI'm still trying to get another alpha out. Not even thinking beta, yet.
I have no clue what that error is about. Moving this over to the CTools queue. Most likely it's not something in AF considering the AF/CTools integration was done by merlinofchaos but he'll know better than me. He is on vacation at the moment, though, and then going to Drupalcon so I wouldn't expect a quick reply.
Michelle
Comment #2
sdboyer commentedI'm actually gonna kick this back to AF - Michelle, from the OP's description, it sounds like a problem with the Forum context's settings form. Looking at the code (
advanced_forum_forum_context_settings_form()), I see you just return an empty array...that could potentially be confusing ctools (that ajax error typically indicates that there was a PHP error somewhere during the callback), but whether or not it is, I'd recommend adding maybe just a markup form element saying something like "The Forum context requires no additional configuration." Otherwise, all people will get is a blank configuration form, which is confusing.Comment #3
michelleAs I said, merlinofchaos wrote the CTools/Panels integration code. I haven't even looked at it. At some point, of course, I will get familiar with the code since I need to be able to maintain the whole module but probably not until closer to release. I also don't like just going in and mucking with code written by the ultimate expert on CTools without making sure there wasn't some intent behind the way it's written. :) So whether it's in my queue or CTools', it needs to wait until merlinofchaos has a moment.
No offense intended to you, sdboyer. I know you know more about CTools than me. Earl will probably tell me I'm just being silly but I feel weird going in and "fixing" code he wrote that I am not familiar with.
Michelle
Comment #4
merlinofchaos commentedHmm. contexts should always have a form, at the very lesat the built in system will add identifier string gadgets. It's possible I did something wrong when setting up the embedded context stuff. I'll have to look into this after Paris.
Comment #5
sdboyer commentedOh no, of course none taken - actually I shoulda read your initial response better, I didn't realize he did the integration.
OH RIGHT. I forgot, they should all at least need to specify their identifier, etc. So somethin is borking up. Don't worry about it Earl, I'll take care of it.
Comment #6
sdboyer commented(in ctools)
Comment #7
merlinofchaos commentedI believe I fixed this in advanced forum.