Posted by Mike Wacker on August 26, 2009 at 1:16am
| Project: | Taxonomy Image |
| Version: | 5.x-1.6 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
When the Resizing Options are set to disabled in the options, the pictures will not display when taxonomy_image_display() is called. Checking the HTML source, I see the
tag, but the following empty attributes are here:
width="" height=""
Those empty attributes cause the image to not display (at least in IE8 it does, probably other browsers, too). When resizing options are turned on, the width and height attributes will have actual numbers in them, and the image will display.
Comments
#1
Bug seems to limit itself to IE users, but obviously that's a very large demographic.
Here's a patch to fix it. Interestingly enough, it looks like this change has already been committed to the 6.x branch and wasn't synced to the 5.x branch.
#2
Put in a patch long ago but forgot to mark as "needs review"
#3
IE6 and 7 are also affected by this issue. They appear to assume that when you have empty width and height attributes, you mean they both = 1. So the images don't disappear. Quite. :)
Anyway, this fixes the issue, and doesn't seem to cause any ill effects for me.