There is an error in the .info file, the feature restriction for the comment styles should be "comment_wrapper" not "comment-wrapper"

Comments

rszrama’s picture

Is this related to me not being able to choose the "Acquia Prosper: Comments - edgy" style as specified in the example configurations?

thill_’s picture

yes, you need to just modify one character in the .info file

stephthegeek’s picture

Commented out the feature restriction in this for now (;skinr[prosper-comments][features][] = comment-wrapper) since the Skinr syntax is changing, will add the restriction back for comments when that's stabilized. Will be in upcoming release.

jeremycaldwell’s picture

Status: Active » Fixed

Comment styles are now working in the latest release of the theme so it works correctly now.

rszrama’s picture

Not sure if this "needs work" or not, but I updated to the latest dev versions of everything and now no longer have a Skinr fieldset on node type edit forms. When I submit the form, I also get:

    * warning: Invalid argument supplied for foreach() in /Applications/MAMP/htdocs/ebony/sites/all/modules/skinr/includes/handlers.inc on line 72.
    * warning: Invalid argument supplied for foreach() in /Applications/MAMP/htdocs/ebony/sites/all/modules/skinr/includes/handlers.inc on line 72.

I suppose I'll post an issue in that module queue.

tresero’s picture

It looks like this does not work at all. Any update on how to change the comment look?

jeremycaldwell’s picture

To style your comments you'll need to go to your content type page (/admin/content/types) and select the content type you'd like to edit. Click on the "edit" link next to your content type and that takes you to your edit page where you can configure the Skinr styles for your content type. Scroll down and click on the "SKINR: COMMENT SETTINGS" and then select "Speech bubbles with pointed edge" which is located under the "Acquia Prosper: comment styles:" heading at the bottom. That will then enable the Skinr style for the comments in your content type.

tresero’s picture

Maybe I have something wrong, but this does not work. I do notice that my version still has: the comments part commented out per #3

jeremycaldwell’s picture

StatusFileSize
new41.08 KB

That's weird that it's not showing for you tresero. I downloaded the latest release of Acquia Prosper and Fusion Core this morning and enabled those themes on a clean install of Drupal6 and it showed up for me. Also be sure that you are running the dev release of the Skinr module. Attached is a screenshot of what I see when I go to my "blog" content type and edit the settings for it. It allows me to select the Skinr styles for my comments.

rszrama’s picture

Interesting. On my site where I updated a previous version, I don't see any Skinr settings in the node edit form. However, on a separate site where I was testing this, the settings show up just fine. That said, selecting the speech bubble style didn't make it look like a speech bubble. : D

jeremycaldwell’s picture

StatusFileSize
new44.59 KB

The "Speech bubble" style is somewhat like a speech bubble :)

Attached is a screenshot of what it should look like. The title text is too large as you can see for each comment but that has been fixed in the version I have now which should be up soon.

Also you might not be seeing it on your other site unless Skinr is running the latest dev release and perhaps run the update.php and clear your site's cache on the Performance page. It's a little difficult to get everything working right away at the moment as everything is in dev releases but once things are settled and finalized things will be a lot easier to manage.

rszrama’s picture

Ahh! Well then, my speech bubble worked fine. I just saw the white background and not the little arrow in the top left corner. I figured it was just grabbing the same white background style that I have on blocks. : P

btw, just so it's not lost in my issues... I love this theme. : D

I hope to roll out a friend's e-commerce site using this sometime soon.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dmendo11’s picture

Version: 6.x-1.x-dev » 6.x-1.1
Component: Code » Documentation
Priority: Normal » Critical
Status: Closed (fixed) » Fixed
StatusFileSize
new797 bytes

Hello All,

So after spending countless hours trying to figure why comments didn't show up correctly with the bubbles, I have found a solution to this problem.

The readme file says to use the Dev File for Skinr 6.x.2.x. Do NOT USE THIS. USE the latest release which is the 6.x-1.6.

I never had issues showing what is on #9, but when I selected the option of Speech Bubbles only a white background would appear.

So I checked in the readme file but it doesn't show me how to make a comment-wrapper.tpl.php file. This is very important for the comment to be themed.

After seaching in the Issues, I found only 1 issue and I guided my self there.

How to show comment in brackets


<?php if ($content) : ?>
<div id="comments" class="comments block">  
<h2 class="comments-header">    
<?php print $node->comment_count ?> <?php print t('Comments'); ?>  
</h2>  
<?php print $content; ?>
</div>
<?php endif; ?>

So I used code and still not showing, only white background on it. I realized that the code he was using wasn't targetting the right class to achieve what shows on #11. So I checked the DEMO which had comments and the correct css information. I used firefox and firebug to see the get the correct css.

This is what I came out with and finally had what #11 displayed.

<?php if ($content) : ?>

<h2 class="comments-header">
    <?php print $node->comment_count ?> <?php print t('Comment(s)'); ?>
</h2>

<div id="comments" class="comments block prosper-comments-edgy">
<?php print $content; ?>
</div>
<?php endif; ?>

It took me about 1 year from the day of installation without any result, I always believed that the comments were suppose to be with a white background. With a little effort and research I found this wasn't true. I would suggest rewriting the Read Me File or adding a comment-wrapper.tlp.php file with Acquia Prosper to avoid further issues. You can use this file to add it to your theme, just rename it to comment-wrapper.tlp.php when you unzip it.

Thank you guys for such a great theme. I hope this helps someone in need!

David

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.