Closed (fixed)
Project:
Profile role
Version:
6.x-1.2
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
26 Aug 2009 at 04:18 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
sinasquax commentedmaybe it's the line 63 :
return user_edit_access($GLOBAL['user']);which must be :
return user_edit_access($user);Because user_edit_access will always return TRUE with $GLOBALS['user'] passed as $account parameter (return (($GLOBALS['user']->uid == $account->uid) || user_access('administer users')) && $account->uid > 0;)
But i don't have tested that !
Comment #2
alioso commentedThat worked and fixed the problem.
This needs to be committed in the next release. This is a pretty big security issue. Good find. Thanks!
Comment #3
clearbrook commentedI'll patch as I load or won't load at all. I'd like to think this should not be advertised unless fixed already. I intend to use this to deal with spammers who are sometimes hackers as well. So this could lead to more mahem than it solves.
Comment #4
colin49 commentedI came across this security bug as well and can verify that sinasquax solution fixes the issue. Hopefully the maintainer will roll that fix into a new release asap.
Comment #5
boombatower commentedSorry about delay, I've been quite busy.
Thanks for posting the fix. I confirmed that it seems to do the job.
Comment #6
boombatower commentedCommitted.