Current implementation does not allow for https on certain requests
cytefx - August 26, 2009 - 12:58
| Project: | Omniture Integration |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
The current implementation of the code, has 2 urls, one for the js code and one for the location of the image (used in the no script)
If you have a larger site that uses SSL for some requests you would have to put these both to ssl to avoid issue with users seeing page insecure issues thought the browser.
To fix this I am suggesting putting in another 2 fields that get called if the page called is in secure (HTTPS) mode. If you have not filled these in then the default will be your existing values.
#1
Here is a patch to include an extra 2 variables that allow for the secure locations of the files, the module will now switch to use the secure variables if the page is requested in a https session
#2
variable_get should always have a default value, even if it is variable_get('something', '');
Otherwise, looks good.
#3
Re-rolled patch, to include the default values for variable_get on the new https variables.
#4
I'm not so sure about this change:
<?php- if (isset($omniture_hooked_vars['variables'])) {
+ if (($omniture_hooked_vars['variables'])) {
?>
The isset should prevent E_NOTICE warnings from PHP.