See your navigation block when visiting drupal.org/planet: there is an empy li. there should be a link back to /planet ie to aggregator/categories/2 but there isn't.

CommentFileSizeAuthor
#1 aggregator.module_13.patch3.25 KBtenrapid

Comments

tenrapid’s picture

Status: Active » Needs review
StatusFileSize
new3.25 KB

The empty list item is caused by a typo in aggregator_menu().

But there is a general issue with the aggregator menu. Some time ago the listing of sources and categories as subitems under the 'news aggregator' menu item was removed to avoid problems with sites that are subscribed to a huge amount of feeds.

With this the 'categories' subitem disappeared because it's a MENU_MENU_ITEM_GROUPING item. But listing the categories as subitems should be no problem as it's independent from the number of feeds you are subscribed to.

The attached patch does the following:
- corrects a typo with the source and category menu item title
- restores the list of categories as subitems under news aggregator -> categories
- makes 'aggregator/sources/'. $feed['fid'] a MENU_CALLBACK
- adapts theme_aggregator_feed() now that the page title is displayed again

drumm’s picture

I think we should save menu rearrangements for 4.8, but typo fixing should certainly go in 4.7.

tenrapid’s picture

Actually this is no menu rearrangement. It's only partially restoring what was lost in rev 1.237.

In Drupal 4.6 the aggregator part of the menu looks like this:

news aggregator
- categories
   - category1
   - category2
   - ...
- sources
   - source1
   - source2
   - ...

Now we have this:

news aggregator
- sources

The 'categories' subitem never shows up, because it's still a MENU_MENU_ITEM_GROUPING item.

With my patch you get the following:

news aggregator
- categories
   - category1
   - category2
   - ...
- sources

Plus page titles are back if you view a single category or source.

tenrapid’s picture

Did someone had the chance to test this?

ahornby’s picture

I applied this patch to my 4.7 RC3 site at www.darlug.org and it applied with no errors and fixed the categories menu. Hope that helps. Anthony.

gerhard killesreiter’s picture

Status: Needs review » Fixed

applied

Anonymous’s picture

Status: Fixed » Closed (fixed)