Download & Extend
Issues

add missing calls to field_attach_preprocess()

Posted by yched on August 27, 2009 at 12:00am
Project:Drupal core
Version:7.x-dev
Component:field system
Category:bug report
Priority:critical
Assigned:pounard
Status:closed (fixed)
Issue tags:translatable fields

Issue Summary

field_attach_preprocess() was (re-)introduced by #367595: Translatable fields, but currently only node module calls it.
Other fieldable entities (users, comments) should call it too. Taxo terms are a little off, because thet're not rendered through a template right now.

Login or register to post comments

Comments

#1

Posted by plach on August 27, 2009 at 8:41am

@yched:

I think at some point we discussed the fact that only nodes would hold translatable fields for now, to limitate UI work. Sorry if I'm on crack and that was dropped later on ?

Yes, that's true, although I'm trying to make the UI work with any fieldable entity. However without this themers needing to access the raw field values would still need to specify the langcode (FIELD_LANGUAGE_NONE), so this is needed. Not critical, though.

#2

Posted by pounard on September 5, 2009 at 10:59am
Assigned to:Anonymous» pounard

#3

Posted by pounard on September 5, 2009 at 11:31am
Status:active» needs review

This is my first shot with field module, patch definitely needs review

AttachmentSizeStatusTest resultOperations
560608.patch1.8 KBIdleFailed: Failed to apply patch.View details

#4

Posted by pounard on September 5, 2009 at 11:33am

Proper file (without header junk)

AttachmentSizeStatusTest resultOperations
560608.patch1.67 KBIdleFailed: Failed to apply patch.View details

#5

Posted by yched on September 5, 2009 at 1:12pm
Status:needs review» needs work

Great !

Aside from the missing '.' at the end of both +  // Preprocess fields comments, this is ready to go

#6

Posted by yched on September 7, 2009 at 7:31pm
Status:needs work» reviewed & tested by the community

Just fixed the comments. RTBC.

AttachmentSizeStatusTest resultOperations
field_attach_preprocess.patch1.6 KBIdleFailed: Failed to apply patch.View details

#7

Posted by System Message on September 10, 2009 at 8:35pm
Status:reviewed & tested by the community» needs work

The last submitted patch failed testing.

#8

Posted by sun.core on January 8, 2010 at 2:02am

This probably needs a re-roll?

#9

Posted by plach on January 8, 2010 at 10:22am
Status:needs work» needs review

Rerolled

AttachmentSizeStatusTest resultOperations
field_attach_preprocess-560608-9.patch1.71 KBIdleFailed on MySQL 5.0 InnoDB, with: 16,822 pass(es), 78 fail(s), and 602 exception(es).View details

#10

Posted by System Message on January 8, 2010 at 10:51am
Status:needs review» needs work

The last submitted patch, field_attach_preprocess-560608-9.patch, failed testing.

#11

Posted by plach on January 8, 2010 at 11:38am
Status:needs work» needs review

This should work.

AttachmentSizeStatusTest resultOperations
field_attach_preprocess-560608-11.patch1.72 KBIdlePassed on all environments.View details

#12

Posted by plach on January 8, 2010 at 11:52am
Status:needs review» reviewed & tested by the community

Green. Setting RTBC per #6.

#13

Posted by webchick on January 10, 2010 at 12:41am
Status:reviewed & tested by the community» fixed

Committed to HEAD.

#14

Posted by System Message on January 24, 2010 at 12:50am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.