I've included a patch with all "coder" module issues fixed. Despite the size of the patch, no changes were done to the current code. Patch is for DRUPAL-6--1.

CommentFileSizeAuthor
#1 article_coding_standards.patch11.04 KBilo
article_coding_standards.patch48.66 KBilo

Comments

ilo’s picture

ilo commented
Status: Active » Needs review
StatusFileSize
new article_coding_standards.patch11.04 KB

sorry, previous patch mixed some backup files. Forget it, this one is the right one..

msameer’s picture

msameer commented

That's not enough to silence coder :(

I'll do some cleanups every now and then until it gets solved...

ilo’s picture

ilo commented

I used coder module DRUPAL-6--2 dev version, with the following options and didn't return any warning.

Drupal Coding Standards (every developer should use)
Drupal Commenting Standards (every developer should use)
Drupal SQL Standards (new review, so use with caution)
Drupal Security Checks (very basic, needs work, but what it finds is good)
Internationalization

and warning level:

minor (most)

msameer’s picture

msameer commented
Status: Needs review » Fixed

I reindented the whole module and pushed that to git.

I don't think I can do more here. The coding style is important but I don't have much time for it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.