I have created a patch to add support for the Active Tags Popular module.

I haven't tested it extensively -- but there isn't much to it so I think it should work across the board.

CommentFileSizeAuthor
#2 patch.patch2.71 KBJaceRider
#1 patch.patch2.94 KBJaceRider
patch.patch2.69 KBJaceRider
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JaceRider’s picture

JaceRider CreditAttribution: JaceRider commented
FileSize
patch.patch2.94 KB

Small fix. New patch.

JaceRider’s picture

JaceRider CreditAttribution: JaceRider commented
FileSize
patch.patch2.71 KB

Patch that fixes an issue with the autocomplete.

mh86’s picture

mh86 CreditAttribution: mh86 commented

I haven't been using Active Tags Popular yet, but I know Active Tags and I think it would be very cool to add the Active Tags Popular too.
The patch basically looks good, except some coding standards, like the indenting of the settings form and the some concatenated strings.

fourmi4x’s picture

fourmi4x CreditAttribution: fourmi4x commented

Active Tags Popular is really awesome to me.
=> Is it planned to add this patch in the next version of Content Taxonomy ? (suscribing!)

dragonwize’s picture

dragonwize CreditAttribution: dragonwize commented

I'll review and test this patch when I get a chance as well. Hopefully this weekend.

JaceRider’s picture

JaceRider CreditAttribution: JaceRider commented

Well, don't review it too closely. I found a lot of issues with it when I brought it over to a different Drupal install. I have a better patch. If I find a spare second I'll take some time and upload the patch.

fourmi4x’s picture

fourmi4x CreditAttribution: fourmi4x commented

Hi JaceRider, do you by any chance have the better patch ? I would really enjoy it and test it !

Izz ad-Din’s picture

Izz ad-Din CreditAttribution: Izz ad-Din commented

Any news on this issue?

looplog’s picture

looplog CreditAttribution: looplog commented

Subscribing. Would like to see these two integrated as well...

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

Marked #670212: Content Taxonomy breaks "tags" as duplicate of this issue.

AntiNSA’s picture

AntiNSA CreditAttribution: AntiNSA commented

i8 really need this. Any way to do it yet?

dragonwize’s picture

dragonwize CreditAttribution: dragonwize commented
Status: Needs review » Needs work

Looking over this patch it seems just to add AT-popular to the field if requested. While that method would work fine for a large majority of people that simply use a CT field with only one vocabulary and no restrictions on that vocabulary, however, it would give incorrect results for all those that used any of the other options in CT because AT would display popular terms from all terms of one vocabulary only.

The normal AT module was easy to integrate as it is purely a front end js widget and uses all of CT's back end including the returned auto complete results so it works easily with all of CTs options. AT-popular is currently written to just return most popular tags on one vocabulary and does so with its own SQL backend.

Because of that AT-popular will need a patch to support CT's options or something more generic that would achieve that goal. I have been meaning to rewrite AT-popular with a much more flexible API so this would be even more of a reason for that.

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
CreditAttribution: rootwork commented

Despite JaceRider's lack of satisfaction with it, the patch from #2 does seem to work.

There are some limitations, such as not being able to have a more than one content taxonomy field using the popular tags in the same node form.

It's great to hear about Active Tags' possible API development, but in the meantime it might be nice to move this into dev so we can provide limited support for Active Tags Popular.

Bartezz’s picture

Bartezz CreditAttribution: Bartezz commented

No news yet?