Like the title says... currently, if you go to the text format configuration page and click on a "delete" link, it gives you a 404 error.

Probably a simple fix, but no time to look into it now.

CommentFileSizeAuthor
#12 drupal.format-delete.12.patch4.75 KBsun
#10 drupal.format-delete.10.patch4.75 KBsun
#8 drupal.format-delete.8.patch4.52 KBsun
#5 format-delete-again.patch1.22 KBDavid_Rothstein
#3 fomat-delete.patch1.19 KBbcn
#1 drupal.format-delete.patch1.2 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new drupal.format-delete.patch1.2 KB

Sorry, my grep for the old path somehow didn't find that instance.

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

bcn’s picture

bcn commented
Status: Needs work » Needs review
StatusFileSize
new fomat-delete.patch1.19 KB

re-roll

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new format-delete-again.patch1.22 KB

Not quite... The patch in #3 uses the wrong URL also.

This one should do it :)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work

ok... we need a test here. ;)

The existing FilterAdminTestCase does not seem to test the overview page.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: +FilterSystemRevamp, +API clean-up

Tagging.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new drupal.format-delete.8.patch4.52 KB

The same with a starting point for "real" text format tests.

Status: Needs review » Needs work

The last submitted patch failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new drupal.format-delete.10.patch4.75 KB

Re-rolled.

Status: Needs review » Needs work

The last submitted patch failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new drupal.format-delete.12.patch4.75 KB

I can't replicate that failure. Same patch for re-test.

dropcube’s picture

dropcube commented
Status: Needs review » Reviewed & tested by the community

Seems good to me. The filter module tests need a rewrite, but that's other issue. RTBC as far as I can see.

dries’s picture

dries commented

Looks good to me too. Committed to CVS HEAD. Thanks.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)
Issue tags: -FilterSystemRevamp, -API clean-up

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +FilterSystemRevamp, +API clean-up

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.