consolidate Solr queries on cron run

robertDouglass - August 27, 2009 - 13:44
Project:Apache Solr Search Integration
Version:5.x-2.x-dev
Component:Code
Category:feature request
Priority:critical
Assigned:claudiu.cristea
Status:closed
Description

In response to some solr server setups that throttle operations, there may be a need for some people to limit the number of delete operations that are sent to the server on cron runs.

AttachmentSize
apachesolr.nodeDeletionFix.patch1.36 KB

#1

robertDouglass - August 27, 2009 - 13:46

I don't really like this implementation for the general public. Is it proven that anyone needs this protection on normal servers, or just servers that have throttling? Also seems like an odd thing to make a configuration for (not that this patch has configuration), so I wouldn't want to go down that route.

#2

pwolanin - October 12, 2009 - 22:06
Version:6.x-2.x-dev» 6.x-1.x-dev
Priority:normal» critical

Let's find a reasonable approach for this asap - it continues to be a problem.

I'm inclined to pt this patch in for the next RC if we don't have something better

#3

pwolanin - October 13, 2009 - 02:26

Here's a mostly untested patch that groups Solr deletes by 500 at a time rather than sending one delete query per node.

This should give better performance in almost all cases, and be more compatible with a limits on update queries.

AttachmentSize
mass-delete-561082-3.patch 6.18 KB

#4

pwolanin - October 13, 2009 - 21:23

That patch isn't really working and doesn't provide a useful count of nodes to be deleted. Here's a better one.

AttachmentSize
throttle-561082-4.patch 7.99 KB

#5

pwolanin - October 13, 2009 - 21:28

With update to README

AttachmentSize
throttle-561082-5.patch 7.99 KB

#6

pwolanin - October 13, 2009 - 21:37

oops - missed README changes

AttachmentSize
throttle-561082-6.patch 8.62 KB

#7

pwolanin - October 14, 2009 - 14:13
Title:Throttle deletes on cron run » consolidate Solr queries on cron run

minor tweak - stop sending updates on cron if one fails.

AttachmentSize
throttle-561082-7.patch 8.76 KB

#8

pwolanin - October 14, 2009 - 19:26
Version:6.x-1.x-dev» 6.x-2.x-dev
Status:needs review» patch (to be ported)

committed to 6.x-1.x

#9

robertDouglass - October 19, 2009 - 14:50
Version:6.x-2.x-dev» 5.x-2.x-dev

And to DRUPAL-6--2

#10

claudiu.cristea - October 23, 2009 - 11:15
Assigned to:Anonymous» claudiu.cristea

The patch for DRUPAL-5--2.

AttachmentSize
throttle-561082-D5.patch 16.99 KB

#11

claudiu.cristea - October 23, 2009 - 11:17
Status:patch (to be ported)» fixed

Fixed in #278744.

#12

System Message - November 6, 2009 - 11:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.