The new entity API has a small, harmless but error-emitting discrepancy in one of the new method signatures. See the patchfile, it says it all.

CommentFileSizeAuthor
#3 taxo_method_sig-2.patch622 bytessdboyer
taxo_method_sig.patch569 bytessdboyer

Comments

sdboyer’s picture

sdboyer commented
Status: Active » Needs review
c960657’s picture

c960657 commented

Shouldn't $conditions be passed to parent::cacheGet() ?

sdboyer’s picture

sdboyer commented
StatusFileSize
new taxo_method_sig-2.patch622 bytes

Mmm, yeah, probably. I left it out on the assumption that whoever originally wrote the code didn't want it to be possible to use conditions with taxonomy terms, but in the absence of any actual knowledge about why it was left out, I figure it's better to err on the side of being less restrictive.

Rerolled.

Status: Needs review » Needs work

The last submitted patch failed testing.

mfb’s picture

mfb
they or he
commented

FYI this is also patched over in #348448: Always report E_STRICT errors

sdboyer’s picture

sdboyer commented
Status: Needs work » Closed (duplicate)

Mmm good ok, I'll dupe this, it's silly to have a whole issue for just the one thing.