Filtering fails to clear cached selections

mikeryan - August 27, 2009 - 22:20
Project:Views Bulk Operations (VBO)
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

Cached selections are held onto for items not in the current view, making it easy to accidentally perform operations on the wrong objects. To reproduce:

  1. Create a Node view with Nid and Title, using Bulk Operations (including the Delete Node operation).
  2. Add an exposed filter on the title.
  3. In the view, select a node and click the Delete Node button. On the confirmation page you see that node title listed. Click the Cancel link.
  4. The node is still selected (as it should be). Filter the view by title so the original node is no longer included in the view.
  5. Select one of the nodes now displayed and click the Delete Node button. Both this node and the original node are now displayed (and will be deleted if you continue).

If you're not alert, or you've disabled confirmation for your actions...

I plan on working on this and supplying a patch next week (but if someone else gets to it first, that would be great...)

Thanks.

#1

kratib - August 28, 2009 - 00:22
Status:active» fixed

Great catch! Thanks for the reproduction scenario. I fixed this in the latest dev, so please try it (12 hours from now) and let me know if it works correctly.

#2

mikeryan - August 28, 2009 - 00:38

Yes, that does the trick - thanks for the quick fix!

#3

System Message - September 11, 2009 - 00:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.