Hello!

I am using Ubercart 6.x-2.0-rc6 on Drupal 6.13 and have a problem with the uc_file module.

The Systems works generally, I can sell products with associated downloads and the buyers can download the files. My problem is the "File downloads" (Files) - menu in "My account":
- Downloads and Addresses are not saved. Every time I go back to this page or reload it after I made a download, "Downloads" is still 0/3 (my setting is max. 3 downloads) and "Addresses" still 1/2 (my setting is max 2 Addresses). These numbers do not get higher and I (admin) and buyers can download their files as many times as they want.
- A even bigger problem: I go to the "File downloads" - menu in "My account", download a file, reload the "File downloads" - page and get the following error messages:

warning: in_array() [function.in-array]: Wrong datatype for second argument in /home/[deleted]/[deleted]/sites/all/modules/ubercart/uc_file/uc_file.pages.inc on line 190.
warning: in_array() [function.in-array]: Wrong datatype for second argument in /home/[deleted]/[deleted]/sites/all/modules/ubercart/uc_file/uc_file.pages.inc on line 334.

I think the problem is "!in_array($ip, $addresses)" in these lines. If the array $addresses is/stays empty, it would explain the error message above and would be the reason why the number of downloads or addresses are not stored.

Is this a general bug or a problem because of my system / other installed modules?

Other information that might be interesting in this case:
Server Linux Debian, Apache 2, MySQL 5.0.X, PHP 5.2X
Ubercart Payment Gateway: Test Gateway (Credit Card)
Installed non-core Ubercart Modules: VAT (uc_vat), Legal aspects checkout pane

CommentFileSizeAuthor
#9 561692_downloads_page.patch2.63 KBIsland Usurper

Comments

tisbris’s picture

tisbris commented

Hi

I do also see this error...

download is ok, downloadcount change - but when you change screen error occur and the downloadcount is reset.

I only use ulimited adresses and only see one error:
warning: in_array() [function.in-array]: Wrong datatype for second argument in /home/www/onleje4.jobbud.dk/modules/ubercart/uc_file/uc_file.pages.inc on line 334.

//Brian

zx2964’s picture

zx2964 commented

I just received a complaint from a customer because of this error. It is the same problem as described above: Addresses and Downloads are not stored, Calling the page several times brings up the error message >>warning: in_array() [function.in-array]: Wrong datatype for second argument<<

murokoma’s picture

murokoma commented

Same Problem here:

warning: in_array() [function.in-array]: Wrong datatype for second argument in /sites/all/modules/ubercart/uc_file/uc_file.pages.inc on line 190.
warning: in_array() [function.in-array]: Wrong datatype for second argument in /sites/all/modules/ubercart/uc_file/uc_file.pages.inc on line 334.

bobba’s picture

bobba commented

I also have the same problem.
Is someone here able to fix that error (or at least hide it)?
For a download shop, this is a very critical problem.

univate’s picture

univate commented

in_array is expecting an array variable as its second argument, that error just means that the $address variable is not an array.

The problem is probably in the unserialize call which really shouldn't occur in these function, it should be moved to where the file data is retrieved from the db.

Vlad-1981’s picture

Vlad-1981 commented

I tested my ebook-shop and it shows these error messages plus the download limits are not working either.

Because I wanted to open my shop to the public this week, this is a very big problem for me.

So how to solve this problem? I am not exactly an expert in programming and the official team of ubercart does not seem to be interested in this problem. At least there is no official statement since this problem was brought up nearly two weeks ago.

Perhaps we should collect some money to let a professional programmer look over it?

bobba’s picture

bobba commented

Any news regarding the error mentioned above?

Is uc_file still actively maintained, or is it time to search for another download-shop-solution that is working correctly?

rszrama’s picture

rszrama commented
Issue tags: +Release blocker

Still maintained.

Island Usurper’s picture

Island Usurper commented
Title: uc_file: warning: in_array() ...: Wrong datatype for second argument in ... uc_file.pages.inc » $addresses is the wrong data type
StatusFileSize
new 561692_downloads_page.patch2.63 KB

Argh. I had made a post before lunch, but someone cleared out all of the sessions on drupal.org again, so it didn't get saved.

Anyhow, I think I've taken care of all of the problems mentioned in this thread. At one point, the addresses were changed to be unserialized when they were loaded from the database, but there seems to have been a spot or two where that didn't get changed.

Island Usurper’s picture

Island Usurper commented
Status: Active » Needs review
Lapurd09’s picture

Lapurd09 commented

Island Usurper,

first of all, thanks for trying to help! I patched my files and the following happened:
- Patch showed no error
- I ran update.php in the modules section after the patch, again no error
- Selling & downloading files is working normally
- The mentioned error-messages are gone

And now to the bad things ...
(again I go the "File downloads" - menu in "My account", download a file and reload the page after the download is finished)
- Instead the following error message is shown:
warning: mysqli_real_escape_string() expects parameter 2 to be string, array given in /home/[deleted]/[deleted]/includes/database.mysqli.inc
- And the downloads and addresses are still not counted (0, 0)

Island Usurper’s picture

Island Usurper commented

I don't see that problem. Can you figure out a way to see which line of code causes that error?

Lapurd09’s picture

Lapurd09 commented

Sorry that my answer might not be very helpful, but I am a user, not a developer.

1) The complete error message says: "warning: mysqli_real_escape_string() expects parameter 2 to be string, array given in /home/-/-/includes/database.mysqli.inc on line 323."

2) This error message only shows when the ip or the download number of a user has to be written to the database. Otherwise everything works ok.

3) This error happens for new users as well as for registered users

4) The database "uc_file_users" has the following data stored for all users:
"accessed" : "0"
"addresses" : "a:0:{}"
"download_limit" : "3"
"address_limit" : "2"

5) Same error when setting download limit and address limit to unlimited

6) My shop is not connected to the public internet at the moment, so no test possible by others.

For me it looks like the data "accesses" and "addresses" can now be read (beforehand it that was not possible and the result were the in_array() errors). But information still can not be written to the database. So the error must be somewhere in the write functions of the download / address limit - checks.

Let's wait and see if someone else has the same problem. If not, than it must be a problem with one of the other modules I use (uc_vat, the tax_line_alter.patch for uc_vat, Legal aspects checkout pane)

Lapurd09’s picture

Lapurd09 commented

Update:
I tested your patch on a fresh installation of drupal 6 and ubercart, and now everything works correctly.

It seems there was a bug in my old drupal/ubercart-system. So forget comments #11 and #13 ;)

Thanks again!

Island Usurper’s picture

Island Usurper commented
Status: Needs review » Fixed

OK, glad you figured it out. Since the patch works, it's committed. Thanks.

j0rd’s picture

j0rd commented

Same issue. Glad there's a patch.

Thanks again
JOrdans

Status: Fixed » Closed (fixed)
Issue tags: -Release blocker

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Release blocker

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.