Posted by soosa on August 27, 2009 at 11:22pm
Jump to:
| Project: | Drupal Contact List Importer |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
It would be much better to have the ability to tell dcl_importer where to find the 3rd party packages that will be used to perform the contact list fetching process, for example, by default the openinviter package will stored at importers/openinviter_engine while for some other reasons any one might need to have it stored at other directory, say /home/me/importer_engines, for example.
For that, i think if the module can have the ability to find the location of the 3rd party packages by specifying this location from a configuration item then that would be a flexibility and even a portability boost for the module to have.
Comments
#1
Note that the include path is already set in a variable in openinviter_engine.module so this should hopefully be as simple as adding a configuration option to the openinviter admin settings form.
The only other problem is that the openinviter engine checks to ensure that the OpenInviter is installed properly already. So I'm not sure how this will be done without breaking that test in the .install file.
#2
Hi Scott,
i have tested what i have asked for in this feature request and it seems that it is doable, the modifications for the code are pretty simple and strait forward, i told dcl_importer to load OI engine from the path {/home/me/Dekstop/importers} rather than the default installation directory and everything worked just fine, it doesn't really matter if you installed OI from within the module it self or from the out side of it, as long as you maintain the structure of OI's files and directories you will be is safe, in other words, if you've got OI installed prior the installation of dcl_importer then you can simply reuse this installation by telling the module where to find the libs files for OI "even if OI files were outside the document root of the webserver" and to do that a small modifications need to take a place in the file {./dcl_importer/importers/openinviter_engine/openinviter_engine.module} and everything will be just fine, i just need the place where to define the configuration item that holds the new path of OI directory and i will patch the module with the proper alters to have this feature implemented.
Thanks.
#3
Ok. I guess just add a new option in openinviter_engine_admin() unless I've misunderstood what you're saying.
Also, take a look at the openinviter_engine_requirements() function in the .install file. The line with file_exists will probably need to change.
#4
This was actually fixed long ago afaik.
#5
Automatically closed -- issue fixed for 2 weeks with no activity.