Closed (fixed)
Project:
Salesforce Suite
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Aug 2009 at 02:31 UTC
Updated:
5 Mar 2010 at 15:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Bevan commentedPlease submit your patch so that others may review and/or collaborate. Thanks!
Comment #2
aaronbaumanI'm using the attached.
trizzo, is this something along the same lines as your solution?
Comment #3
vfilby commentedI just came across the same problem and I applied (manually) aaronbauman's patch, it seems to have resolved the issue with new nodes not being created.
Comment #4
vfilby commentedI was running into patch conflicts so I started fresh from salesforce-dev and started reapplying the patches. When I applied this patch via the patch command it caused problems. The problem was that:
was changed to:
by the patch. I am not sure how the changes to
$dataaffect the$nidif block. This is a relatively small, but annoying bug. We should get this tested and into the core.This patch is the same as Arron's from #2, but I have removed the changes to
$data->fieldsComment #5
aaronbaumanThanks vfilby,
I've been hacking this module for various clients who use the Partner API Client, which for some reason defines its data structures just differently enough to be really really annoying.
At first glance, this patch works for me on a fresh install.
Let's get another review and get this in.
Comment #6
dago.aceves commentedI ran into this problem as well and I'm working on rewriting the sf_import module right now to handle both users and nodes on import. I'm curious if the salesforce project is considering adding sf_import and if there is interest in me putting up the module once its done.
My changes to sf_node_import are similar to the patch on this post, so i just applied your patch to a fresh sf_node install.
The project I'm working on right now is going to be working very tightly with salesforce operations. I'm curious what the plans are with this project.
Comment #7
kostajh commenteddago.aceves, I'm also working on a project to tightly integrate salesforce operations with a Drupal site. Myself and another developer will probably do some work on this module and contribute back whatever we develop.
Comment #8
Bevan commentedkostajh and dago; Currently development has kind of stalled since neither JoshK nor I are actively developing websites that use this module (Aaron has been more active recently, but I'm not sure what his current status is). I can't speak for Josh, but I think he would agree that we're happy to add maintainers if they can show the quality of their contributions through patches here in the issues queue, have CVS accounts, and ask nicely. ;)
What Salesforce module really needs is someone to invest a developer in it for a few months to work through the issue queue, get a stable release out, support it, and start committing some of the many awesome features in the queue and creating new d.o projects for integration modules.
Comment #9
trevortwining commentedI have applied the patch and it works successfully from the most recent version of HEAD using a setup with the Enterprise WDSL. thanks for the patch! It's pretty simple, as long as one of the maintainers has no problems with its current form I'd say it works as advertised.
Comment #10
Anonymous (not verified) commentedI also applied the patch, and it works successfully from the 6.x-2.x-dev version. Thanks!
Comment #11
Bevan commentedComment #12
aaronbaumancommitted http://drupal.org/cvs?commit=330848