In this module 'jquery.pngFix.js' file is old - sometimes it's not working properly.
Now it has version 1.1...

* Changelog:
 *    09.03.2009 Version 1.2
 *    - Update for jQuery 1.3.x, removed @ from selectors

You can download new file at http://jquery.andreaseberhard.de/pngFix/

Comments

Daugilas’s picture

Daugilas commented
Category: bug » feature

it also apllies for 6x-1.x-dev

robloach’s picture

robloach
he/him
commented
Version: 6.x-1.0 » 6.x-1.x-dev

The thing about version 1.2 is that it's for jQuery 1.3, which isn't available for Drupal 6 without jQuery Update. Maybe if we make a new branch that depends on jQuery Update? What are your thoughts?

Thanks a lot,
Rob

epiphanydigital’s picture

epiphanydigital commented

Why not just make it detect if jQuery update is enabled and pick a version to use depending on that?

shane birley’s picture

shane birley commented

It should depend upon jquery update as that module already does what you propose. No need to duplicate functionality.

shane birley’s picture

shane birley commented

So, Rob, yah. I think breaking it into the next version number (is it 2.x?) and then making it dependent upon jQuery Update module is probably the way to go.

Countzero’s picture

Countzero commented

Still a problem now.

The manual upgrade of the file solves it but there's no error message nor documentation explaining where to look to find this solution.

Thanks for it anyway.

Anonymous’s picture

Anonymous (not verified) commented

Would be nice to have a notice on the front page for people using jQuery 1.3.

Note that the downlolad link incorrectly labels the png_fix version as 1.1 though it really is version 1.2.

luketarplin’s picture

luketarplin commented
Category: feature » bug

Pngfix didn't work for me until I updated the Jquery.pngfix.js script to version 1.2, The selectors were correct, I was getting a js error when it was attempting to do its stuff on an image! I have other jscript libraries installed most notably Cufon, so not sure if its a compatibility thing.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented
Title: update jquery.pngFix.js » update jquery.pngFix.js (...or provide support for the Libraries API)

...subscribing. This can be taken care of if the module is updated to provide support for the Libraries API. Once this feature is implemented, each one can update their setups by simply downloading the newest version of the .js file and placing it under ../sites/all/libraries/pngFix/. This way we'll be able to update the module and/or the .js file independently from each other.

shane birley’s picture

shane birley commented
Issue summary: View changes
Status: Active » Closed (outdated)