Hello. This is really nice implemented. Took the load off some work I had to do on a DIBS integration. Perfect!

I have a little sugestion. In the accept callback of dibsapi it would be really nice to include the transaction id if this is possible.

Comments

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
commented

Hi,

I am glad that you liked the module :-)

The transaction id should be included in the $transaction object argument in the hook_dibsapi(). Something like $transaction->payment_transaction_id.

If it is not included in the transaction object, might it be because the automatic callback from DIBS not has been made yet.

A thing that I might do is to update the transaction in the dibs_frontend_accept_page() function, if it does not include the transaction id already. For example id the automatic callback has not been executed yet.

Let me know if you still have the problem.

Bests,
Jens

mnlund’s picture

mnlund commented

You are completely right. It's there. Just me who didn't see it at first.

I'm going to use this module on some other projects. Do you consider it stable, or is it something I should look out for? I can see that the transaction list handling isn't implemented yet. Is this planned, or? Just wondering. Find this module most useful.

Thanks!

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
commented

The only issues that exists right now are in the issue queue. We are using the DIBS module our selves for a project, and have not experienced other problems than that.

The transactions list in the administrations is ofcourse planned, I have had the time to make it though. I hope to have the things fixed in September, but my schedule is also quite busy in September (Con in Paris + 2 weeks postponed sommer vacation) ;-)

beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
commented
Status: Active » Closed (works as designed)