Download & Extend
Issues

Decreasing the spacing on <li> in listing items

Posted by Bojhan on August 28, 2009 at 2:32pm
Project:Drupal core
Version:7.x-dev
Component:Seven theme
Category:task
Priority:normal
Assigned:BarisW
Status:closed (fixed)
Issue tags:D7UX, Usability

Issue Summary

Rather undescriptive text, but pretty much going from.

http://screencast.com/t/vyZRsVQr

To something like

http://screencast.com/t/IHfXqzWTu (dont mind the bottom spacing, and tiny blocks)

Login or register to post comments

Comments

#1

Posted by sreynen on August 31, 2009 at 5:43pm
Status:active» fixed

A fresh d7 install no longer has these spacing issues.

#2

Posted by Bojhan on August 31, 2009 at 9:16pm
Status:fixed» active

Wait, what? no that's impossible.

#3

Posted by BarisW on September 1, 2009 at 9:18am
Assigned to:Anonymous» BarisW

I think it would be best to descrease the margin on #block-system-main ul.admin-list li and increase the margin on div.admin-panel .description
By doing so, we only use the margin on the Module page where the descriptions are enabled.

I'll give it a shot!

#4

Posted by BarisW on September 1, 2009 at 11:31am
Status:active» needs review

Changing padding and margin settings on ul.admin-list.compact is all that´s needed.

AttachmentSizeStatusTest resultOperations
seven_css.patch699 bytesIdlePassed: 12852 passes, 0 fails, 0 exceptionsView details

#5

Posted by BarisW on September 1, 2009 at 2:17pm

And the screenshot

AttachmentSizeStatusTest resultOperations
li-spacing.png8.29 KBIgnored: Check issue status.NoneNone

#6

Posted by Bojhan on September 1, 2009 at 2:19pm
Status:needs review» reviewed & tested by the community

Good to go.

#7

Posted by webchick on September 11, 2009 at 12:57am
Status:reviewed & tested by the community» needs review

I totally do not see the difference between before/after. Can someone help by posting a before/after screenshot with some arrows or something?

The "to something like" in the initial post looks absolutely hideous, so I'm really hoping that's not what we're shooting for. ;)

#8

Posted by sign on September 11, 2009 at 8:33am

there is a colon at the end of one line instead of semicolon
note: this is for when compact mode is enabled (hidden description)

screens attached

AttachmentSizeStatusTest resultOperations
compact_mode_before.png6.89 KBIgnored: Check issue status.NoneNone
compact_mode_after.png6.66 KBIgnored: Check issue status.NoneNone
562284_decreasing_the_spacing_8.patch683 bytesIdlePassed: 12949 passes, 0 fails, 0 exceptionsView details

#9

Posted by Bojhan on September 11, 2009 at 8:40am
Status:needs review» reviewed & tested by the community

Ok, back to RTBC. It was broken apparently, weird - when I tested it before it applied cleanly, maybe my HEAD was conflicting.

We are not shooting for whats in the screenshot in the initial post no :P, that was me being crazy with firebug

#10

Posted by Dries on September 11, 2009 at 1:39pm
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD.

#11

Posted by System Message on September 25, 2009 at 1:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.