This patch allows Massmailer to use CURL to perform mail sending functions.

Also, I'd like to note that I can't take credit for this...I just tested and posted it.

Robin

CommentFileSizeAuthor
#6 massmailer_no_cli_fixed.patch3.97 KBrobin monks
#3 massmailer_without_cli.patch.txt5.04 KBkilles@www.drop.org
#1 massmailer_without_cli.patch9.83 KBrobin monks

Comments

robin monks’s picture

robin monks commented
StatusFileSize
new massmailer_without_cli.patch9.83 KB

project.module ate my attachment...

Robin

killes@www.drop.org’s picture

killes@www.drop.org commented

The patch is quite unclean and also not against the most recent version of phplist.module. Can I assume that the important changes are in phplist_process_queue? Any other changes that matter?

killes@www.drop.org’s picture

killes@www.drop.org commented
StatusFileSize
new massmailer_without_cli.patch.txt5.04 KB

I've cleaned the patch a bit. There are several places where I disagree with the patch.

-// Drupal sends mails in 8bit mode
-define('TEXTEMAIL_ENCODING','8bit');
-
-// We use PHPmailer for sending.
-define("PHPMAILER",1);
-

@@ -780,7 +780,7 @@ function phplist_send_mail($lids, $mid,

Amazon’s picture

Amazon commented

Robin, could looking into cleaning up the config file.

patch -p0 -u < ../../massmailer_without_cli.patch.txt
patching file engines/phplist/config.php
Hunk #1 FAILED at 74.
1 out of 2 hunks FAILED -- saving rejects to file engines/phplist/config.php.rej
patching file engines/phplist/phplist.module

pauln600’s picture

pauln600 commented

This patch also needs changes to PHPlist... more to come.

Paul N.

robin monks’s picture

robin monks commented
StatusFileSize
new massmailer_no_cli_fixed.patch3.97 KB

I just tested the attached patch to work on a new CivicSpace install. There was a small error which Paul Newby found and I corrected in this illiteration.

Robin

robin monks’s picture

robin monks commented

Gerhard, what changes will be needed before you commit this patch?

Robin

killes@www.drop.org’s picture

killes@www.drop.org commented

Robin, why are these changes in the patch?

-// Drupal sends mails in 8bit mode
-define('TEXTEMAIL_ENCODING','8bit');
-
-// We use PHPmailer for sending.
-define("PHPMAILER",1);
-

Paul said he didn't make them.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs review » Active

applied the patch minus the parts that didn't belong there. Awaiting sql changes.

killes@www.drop.org’s picture

killes@www.drop.org commented

manual processing of the mail queue seems to log users out.

pauln600’s picture

pauln600 commented

I'm not quite sure what you mean - manual being via the phplist admin interface directly?

Paul N.

killes@www.drop.org’s picture

killes@www.drop.org commented

manual through the link we present in the Drupal admin menu.

pauln600’s picture

pauln600 commented

After you run it, you need to log back in to Drupal?

Paul N.

killes@www.drop.org’s picture

killes@www.drop.org commented

yes

pauln600’s picture

pauln600 commented

Hm, I'm not seeing that in my install... anyone else?

The session handler is switched to 'files' in phplist config.php. What's the session handler set to in your drupal site settings.php?

Paul N.

killes@www.drop.org’s picture

killes@www.drop.org commented

"user" as Drupal requires. It is possible my install is borked. But if phplist changes sets the session handler to files then problems are almost guaranteed.

pauln600’s picture

pauln600 commented

Please explain.

Paul N.

killes@www.drop.org’s picture

killes@www.drop.org commented

Drupal calls several session function during a page request. All these functions assume that the cookie information is stored in our database (this is what session handler = user means to us) so if they can't find the info because the sessionhandler changed, I expect problems.

pauln600’s picture

pauln600 commented

PHPlist switches the session handler to 'files' and exits on completion. Since any session data in PHPlist would be saved in the filesystem, it shouldn't interfere with the Drupal session data.

pauln600’s picture

pauln600 commented

... also the PHPlist session_start fails because it's preceded by the Drupal session. If it didn't, we would need to disable it to prevent subsequent PHPlist admin access without login.

Pau N.

datura-1’s picture

datura-1 commented
Title: Allow PHPList to use CURL instead of relying on CLI functions. » You're not actually logged out...

Take a look at this code:

  $ch = curl_init();
  curl_setopt($ch, CURLOPT_URL, $base_url.'/modules/massmailer/engines/phplist/phplist/admin/?page=processqueue' );
  curl_setopt($ch, CURLOPT_POST, 1 );
  curl_setopt($ch, CURLOPT_POSTFIELDS, $postdata);
  curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
  echo str_replace('<head>',"<head><base href=\"$base_url/modules/massmailer/engines/phplist/phplist/admin/\">",curl_exec($ch));
  exit;

What's happening is that the CURL is trying to access a page that drupal cannot find and returns that to the browser. Since it is CURL accessing the page, and the CURL user is not logged in to drupal, you see "Page not found" and it looks like you're not logged in. But really it is CURL that is not logged in.

The real issue is that the URL that CURL is trying to fetch is not a valid path...I'm digging into that part now.

Considering I haven't yet seen this thing work, any words of encouragement that this is a worthwhile endeavor would be greatly appreciated ;-)

dalin’s picture

dalin
he/him
Primary language English
Location 🇨🇦, 🇲🇽, 🌍
commented

I've managed to get everything except unsubscribe working. Take a look at these issues:

http://drupal.org/node/60205
http://drupal.org/node/61766